Skip to content

staging:iio:tsl2583 update interfaces

Jonathan Cameron linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging:iio:light:tsl2583 use read_raw, write_raw hooks.drivers/staging/iio/light/tsl2583.c+85 -1020 replies
2/3staging:iio:light:tsl2583 apply in_ prefix to attributes.drivers/staging/iio/light/tsl2583.c+12 -120 replies
3/3staging:iio:light:tsl2583 switch to kstrto and strtobooldrivers/staging/iio/light/tsl2583.c+22 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/3 V2] staging:iio:tsl2583 update interfaces

Final patch fixed so it doesn't contain a typo that prevents it compiling. Sorry about that.

This driver is now fairly old and has lagged a bit as we have brought in newer cleaner ways of doing things. Anyhow, I was looking at it with a view to moving it out of staging and thought I would clean up a few bits whilst doing so. Note I don't have one of these.

There are some 'unusual' interfaces in here still such as integrationtime. We need to have a think about whether we want to add these to the info mask and handle them through read/write_raw or not.

I'm also decidely unkeen on the manual power enable / disable that is still in this driver. That should ideally be done on demand.

Hence i am not proposing moving this out of staging just yet!

Jonathan

Jonathan Cameron (3):
staging:iio:light:tsl2583 use read_raw, write_raw hooks. staging:iio:light:tsl2583 apply in_ prefix to attributes. staging:iio:light:tsl2583 switch to kstrto and strtobool

 drivers/staging/iio/light/tsl2583.c | 247 +++++++++++++++++-------------------
 1 file changed, 119 insertions(+), 128 deletions(-)
Signature · 1 line
1.8.1