Skip to content

spi/pxa2xx: add Intel Lynxpoint SPI controller support

Mika Westerberg lkml 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am 1358850393-23111-1-git-send-email-mika.westerberg@linux.intel.com

Versions newest first · linked by author and title

  1. v3 Latest10 patches 19 repliesApplied
  2. v210 patches 3 repliesSuperseded
  3. v111 patches 31 repliesApplied

Changes to v2 from the cover letter

- Added parens to IS_DMA_ALIGNED(x) parameter.
- Prefix the DMA function names with pxa2xx_spi_ so that we don't pollute the global kernel namespace with too generic symbols.
- By default select the DMA engine API support even on PXA and treat the PXA private DMA API as legacy. It can still be selected via Kconfig option CONFIG_SPI_PXA2XX_PXADMA.
- Update patch [5/10] title to match better what it does.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10spi/pxa2xx: allow building on a 64-bit kerneldrivers/spi/Kconfig+2 -21 reply
2/10spi/pxa2xx: fix warnings when compiling a 64-bit kerneldrivers/spi/spi-pxa2xx.c+2 -31 reply
3/10spi/pxa2xx: convert to the pump message infrastructuredrivers/spi/spi-pxa2xx.c+12 -2001 reply
4/10spi/pxa2xx: convert to the common clk frameworkdrivers/spi/spi-pxa2xx.c include/linux/spi/pxa2xx_spi.h+20 -311 reply
5/10spi/pxa2xx: break out the private DMA API usage into a separate filedrivers/spi/Kconfig drivers/spi/Makefile drivers/spi/spi-pxa2xx-pxadma.c +3 more+712 -6483 replies
6/10spi/pxa2xx: add support for DMA enginedrivers/spi/Kconfig drivers/spi/Makefile drivers/spi/spi-pxa2xx-dma.c +3 more+437 -32 replies
7/10spi/pxa2xx: add support for runtime PMdrivers/spi/spi-pxa2xx.c+67 -61 reply
8/10spi/pxa2xx: add support for SPI_LOOPdrivers/spi/spi-pxa2xx.c+4 -11 reply
9/10spi/pxa2xx: add support for Intel Low Power Subsystem SPIdrivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h include/linux/pxa2xx_ssp.h +1 more+145 -41 reply
10/10spi/pxa2xx: add support for Lynxpoint SPI controllersdrivers/spi/Kconfig drivers/spi/spi-pxa2xx.c+109 -31 reply

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/10
2/10
3/10A-b
4/10
5/10A-b
6/10A-b
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

Hi all,

This is third iteration of the patches. The second version is available here:

	http://lkml.org/lkml/2013/1/21/108

On Intel Lynxpoint (the PCH used with Haswell) we have two SPI controllers that reside in the Low Power Subsystem of the PCH. The hardware is mostly compliant with PXA2xx SPI controller except that there are few additional registers. Those are described in patch [9/10].

Changes to v2:
- Added parens to IS_DMA_ALIGNED(x) parameter.
- Prefix the DMA function names with pxa2xx_spi_ so that we don't pollute the global kernel namespace with too generic symbols.
- By default select the DMA engine API support even on PXA and treat the PXA private DMA API as legacy. It can still be selected via Kconfig option CONFIG_SPI_PXA2XX_PXADMA.
- Update patch [5/10] title to match better what it does.

Changes to v1:
- Split 64-bit build support and warnings fix into separate patches [1,2/10].
- Convert to use common clk API instead of passing the clock rate via custom platform data parameter.
- Split the DMA implementation into a separate files for PXA and DMA engine.

I've dropped the two patches that are already applied in Mark's SPI tree.

Tested on Haswell machine with both DMA and PIO modes. Only compile tested on PXA (due to lack of hardware).

Mika Westerberg (10):
spi/pxa2xx: allow building on a 64-bit kernel
spi/pxa2xx: fix warnings when compiling a 64-bit kernel spi/pxa2xx: convert to the pump message infrastructure spi/pxa2xx: convert to the common clk framework spi/pxa2xx: break out the private DMA API usage into a separate file spi/pxa2xx: add support for DMA engine
spi/pxa2xx: add support for runtime PM
spi/pxa2xx: add support for SPI_LOOP
spi/pxa2xx: add support for Intel Low Power Subsystem SPI spi/pxa2xx: add support for Lynxpoint SPI controllers

 drivers/spi/Kconfig             |   15 +-
 drivers/spi/Makefile            |    5 +-
 drivers/spi/spi-pxa2xx-dma.c    |  392 ++++++++++++++
 drivers/spi/spi-pxa2xx-pxadma.c |  490 ++++++++++++++++++
 drivers/spi/spi-pxa2xx.c        | 1092 ++++++++++++---------------------------
 drivers/spi/spi-pxa2xx.h        |  221 ++++++++
 include/linux/pxa2xx_ssp.h      |    9 +
 include/linux/spi/pxa2xx_spi.h  |  105 +---
 8 files changed, 1469 insertions(+), 860 deletions(-)
 create mode 100644 drivers/spi/spi-pxa2xx-dma.c
 create mode 100644 drivers/spi/spi-pxa2xx-pxadma.c
 create mode 100644 drivers/spi/spi-pxa2xx.h
Signature · 1 line
1.7.10.4