Skip to content

RFC staging: alarm-dev: compat_ioctl support

John Stultz lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: alarm-dev: Refactor alarm-dev ioctl code in prep for compat_ioctldrivers/staging/android/alarm-dev.c+146 -960 replies
2/2staging: alarm-dev: Implement compat_ioctl supportdrivers/staging/android/alarm-dev.c drivers/staging/android/android_alarm.h+67 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support

This is a first-pass at implementing compat_ioctl support for Android's alarm-dev driver in staging.

The first patch is some refactoring to cleanup and separate the copying of user data from the logic, and the second patch adds the compat_ioctl support.

As noted in the patch, the only really squirly bit is the handling of ANDROID_ALARM_SET_OLD and ANDROID_ALARM_SET_AND_WAIT_OLD. These are present to support existing older Android applications. Unfortunately these cause ioctl number aliasing issues with the compat ioctls, so on 64bit they are only supported in the compat patch (since any existing android app old enough to use them are likely 32bit).

I'd appreciate feedback from the Android devs on if this is an ok assumption and if it might be reasonable to establish some sort of a phase-out timeline for the _OLD ioctl support.

Any other feedback or thoughts would be welcome!

thanks
-john

Cc Greg KH <[email protected]>
Cc Serban Constantinescu <[email protected]>
Cc Arve Hjønnevåg <[email protected]>
Cc Android Kernel Team <[email protected]>

John Stultz (2):
staging: alarm-dev: Refactor alarm-dev ioctl code in prep for
compat_ioctl
staging: alarm-dev: Implement compat_ioctl support

 drivers/staging/android/alarm-dev.c     |  290 +++++++++++++++++++++----------
 drivers/staging/android/android_alarm.h |   19 ++
 2 files changed, 213 insertions(+), 96 deletions(-)
Signature · 1 line
1.7.10.4