RFC saa7134: improve v4l2-compliance
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | saa7134: v4l2-compliance: implement V4L2_CAP_DEVICE_CAPSdrivers/ | +31 | 1 reply | |
| 2/7 | saa7134: v4l2-compliance: don't report invalid audio modes for radiodrivers/ | +1 | 1 reply | |
| 3/7 | saa7134: v4l2-compliance: use v4l2_fh to fix priority handlingdrivers/ drivers/ drivers/ | +10 | 1 reply | |
| 4/7 | saa7134: v4l2-compliance: return real frequencydrivers/ drivers/ | +4 | 1 reply | |
| 5/7 | saa7134: v4l2-compliance: fix g_tuner/s_tunerdrivers/ | +4 | 1 reply | |
| 6/7 | saa7134: v4l2-compliance: remove V4L2_IN_ST_NO_SYNC from enum_inputdrivers/ | +0 | 3 replies | |
| 7/7 | saa7134: v4l2-compliance: remove bogus audio input supportdrivers/ | +0 | 1 reply |
Reviews trailers per patch
5 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Hans Verkuil |
|---|---|
| Series | A-b |
| 1/7 | |
| 2/7 | A-b |
| 3/7 | A-b |
| 4/7 | A-b |
| 5/7 | A-b |
| 6/7 | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/7] saa7134: improve v4l2-compliance
Hello,
this patch series improves v4l2-compliance of saa7134 driver. There are still some problems. Controls require conversion to control framework which I was unable to finish (because the driver accesses other controls and also the file handle from within s_ctrl).
Radio is now OK except for controls.
Video has problems with controls, debugging, formats and buffers:
Debug ioctls:
test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported)
fail: v4l2-test-debug.cpp(84): doioctl(node, VIDIOC_DBG_G_CHIP_IDENT, &chip)
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
fail: v4l2-test-formats.cpp(836): !cap->readbuffers
test VIDIOC_G/S_PARM: FAIL
fail: v4l2-test-formats.cpp(335): !fmt.width || !fmt.height
test VIDIOC_G_FBUF: FAIL
fail: v4l2-test-formats.cpp(382): !pix.colorspace
Buffer ioctls:
fail: v4l2-test-buffers.cpp(109): can_stream && !mmap_valid && !userptr_valid && !dmabuf_valid
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
Haven't looked into VBI yet:
Format ioctls:
fail: v4l2-test-formats.cpp(914): G/S_PARM is only allowed for video capture/output
test VIDIOC_G/S_PARM: FAIL
fail: v4l2-test-formats.cpp(432): vbi.reserved not zeroed
fail: v4l2-test-formats.cpp(570): VBI Capture is valid, but TRY_FMT failed to return a format
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(432): vbi.reserved not zeroed
fail: v4l2-test-formats.cpp(728): VBI Capture is valid, but no S_FMT was implemented
test VIDIOC_S_FMT: FAIL
Signature · 1 line
Ondrej Zary