Skip to content

dasd: implement block timeout

Hannes Reinecke lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 1 replyIn review
  2. v19 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Fixed lock inversion in dasd_times_out()
- Checked for 'device->block' when writing to 'timeout' attribute
- Check against 'UINT_MAX' when verifying the 'timeout' value

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9dasd: Clarify commentdrivers/s390/block/dasd.c+1 -30 replies
2/9dasd: make number of retries configurabledrivers/s390/block/dasd_devmap.c drivers/s390/block/dasd_diag.c drivers/s390/block/dasd_eckd.c +2 more+57 -60 replies
3/9dasd: process all requests in the device taskletdrivers/s390/block/dasd.c+2 -20 replies
4/9dasd: Implement block timeout handlingdrivers/s390/block/dasd.c drivers/s390/block/dasd_diag.c drivers/s390/block/dasd_eckd.c +1 more+88 -20 replies
5/9dasd: Reduce amount of messages for specific errorsdrivers/s390/block/dasd_erp.c+8 -00 replies
6/9dasd: detailed I/O errorsblock/blk-core.c drivers/s390/block/dasd.c+16 -30 replies
7/9block: check for timeout function in blk_rq_timed_out()block/blk-timeout.c+3 -20 replies
8/9dasd: Add 'timeout' attributedrivers/s390/block/dasd.c drivers/s390/block/dasd_devmap.c drivers/s390/block/dasd_int.h+62 -00 replies
9/9dasd: Fail all requests when DASD_FLAG_ABORTIO is setarch/s390/include/uapi/asm/dasd.h drivers/s390/block/dasd.c drivers/s390/block/dasd_int.h +1 more+76 -30 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Weinhuber
SeriesA-b
1/9
2/9
3/9
4/9A-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/9][v2] dasd: implement block timeout

This patch series implements a block timeout handler for DASDs. The main impetus was to allow for a fixed upper timeout value after which a request is aborted. This is required eg when implementing a host-based mirroring system where otherwise the entire mirror would stall under certain circumstances.

Changes since v1:
- Fixed lock inversion in dasd_times_out()
- Checked for 'device->block' when writing to 'timeout' attribute
- Check against 'UINT_MAX' when verifying the 'timeout' value

Hannes Reinecke (9):
dasd: Clarify comment
dasd: make number of retries configurable
dasd: process all requests in the device tasklet
dasd: Implement block timeout handling
dasd: Reduce amount of messages for specific errors
dasd: detailed I/O errors
block: check for timeout function in blk_rq_timed_out()
dasd: Add 'timeout' attribute
dasd: Fail all requests when DASD_FLAG_ABORTIO is set

 arch/s390/include/uapi/asm/dasd.h |    4 +
 block/blk-core.c                  |    3 +
 block/blk-timeout.c               |    5 +-
 drivers/s390/block/dasd.c         |  115 +++++++++++++++++++++++++++++++++----
 drivers/s390/block/dasd_devmap.c  |   97 +++++++++++++++++++++++++++++++
 drivers/s390/block/dasd_diag.c    |    8 ++-
 drivers/s390/block/dasd_eckd.c    |   15 ++++-
 drivers/s390/block/dasd_erp.c     |    8 +++
 drivers/s390/block/dasd_fba.c     |   10 +++-
 drivers/s390/block/dasd_int.h     |   10 +++
 drivers/s390/block/dasd_ioctl.c   |   59 +++++++++++++++++++
 11 files changed, 313 insertions(+), 21 deletions(-)
Signature · 1 line
1.7.4.2