Skip to content

spi/bcm63xx: fix multi transfer messages

Jonas Gorski linux-spi 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 7 repliesApplied

Changes in v2 from the cover letter

* split into two patches
* fixed return type of bcm63xx_txrx_bufs()
* slightly reworked bcm63xx_txrx_bufs, obsoleting one local variable
* added a bit more comments in the code
* added error messages indicated why transfers were rejected

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2spi/bcm63xx: reject transfers unable to transferdrivers/spi/spi-bcm63xx.c+42 -491 reply
2/2spi/bcm63xx: work around inability to keep CS updrivers/spi/spi-bcm63xx.c+106 -283 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFlorian Fainelli
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

The bcm63xx SPI controller does not support keeping CS up after doing a transfer. Since this is problematic for most typical use cases, this patchset introduces a workaround by combining small enough messages to one transfer, rejecting anything that can't be fulfilled with the hardware.

Patch one properly rejects anything impossible to transfer with these limitations.
Patch two introduces logic for combining transfers to one to be able to use it for typical use cases (register accesses and flash access).

Build and run tested on a BCM6368 with a SPI controlled switch attached requiring write-then-read with CS asserted.

Changes V1 -> V2:
* split into two patches
* fixed return type of bcm63xx_txrx_bufs()
* slightly reworked bcm63xx_txrx_bufs, obsoleting one local variable
* added a bit more comments in the code
* added error messages indicated why transfers were rejected

Jonas Gorski (2):
spi/bcm63xx: reject transfers unable to transfer spi/bcm63xx: work around inability to keep CS up

 drivers/spi/spi-bcm63xx.c |  179 +++++++++++++++++++++++++++++++--------------
 1 file changed, 125 insertions(+), 54 deletions(-)
Signature · 8 lines
1.7.10.4


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan