Skip to content

Input: ALPS - Clean up and rework driver to support newer touchpads

Kevin Cernekee linux-input 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest14 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14Input: ALPS - Document the alps.h data structuresdrivers/input/mouse/alps.h+61 -130 replies
2/14Input: ALPS - Copy "model" info into alps_data structdrivers/input/mouse/alps.c drivers/input/mouse/alps.h+43 -340 replies
3/14Input: ALPS - Move alps_get_model() down below hw_init codedrivers/input/mouse/alps.c+93 -930 replies
4/14Input: ALPS - Introduce helper function for repeated commandsdrivers/input/mouse/alps.c+30 -410 replies
5/14Input: ALPS - Rework detection sequencedrivers/input/mouse/alps.c drivers/input/mouse/alps.h+56 -750 replies
6/14Input: ALPS - Use function pointers for different protocol handlersdrivers/input/mouse/alps.c drivers/input/mouse/alps.h+54 -540 replies
7/14Input: ALPS - Move {addr,nibble}_command settings into alps_set_defaults()drivers/input/mouse/alps.c+4 -80 replies
8/14Input: ALPS - Rework detection of Pinnacle AGx touchpadsdrivers/input/mouse/alps.c+12 -30 replies
9/14Input: ALPS - Fix command mode checkdrivers/input/mouse/alps.c+1 -10 replies
10/14Input: ALPS - Move pixel and bitmap info into alps_data structdrivers/input/mouse/alps.c drivers/input/mouse/alps.h+33 -220 replies
11/14Input: ALPS - Make the V3 packet field decoder "pluggable"drivers/input/mouse/alps.c drivers/input/mouse/alps.h+95 -440 replies
12/14Input: ALPS - Add support for "Rushmore" touchpadsdrivers/input/mouse/alps.c+52 -00 replies
13/14Input: ALPS - Enable trackstick on Rushmore touchpadsdrivers/input/mouse/alps.c+115 -700 replies
14/14Input: ALPS - First attempt at "Dolphin" touchpad supportdrivers/input/mouse/alps.c drivers/input/mouse/alps.h+101 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 00/14] Input: ALPS - Clean up and rework driver to support newer touchpads

Several modern ALPS devices require slight variations on existing driver functions. This patchset provides a way to "mix and match" various components, to avoid excessive code duplication and clutter:

- Separating the report format decoding from processing, so that Pinnacle AGx, Rushmore, and Dolphin touchpads can use a common processing function.

- Allowing devices with different register layouts to use the same processing functions but disparate init functions.

- Providing a way to discover touchpads like Pinnacle AGx and Rushmore, which are identified by a range of EC report values rather than an exact match to a specific E7 report sequence.

- Storing the bitmap and pixel constants in the alps_data struct, so they can be updated if the device uses different values (ala Dolphin).

V1->V2 changes with respect to Rushmore support:

- Fix MT and trackstick report decoding (credit to Emmanual Thome)

Baseline:

git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next

git pull from:

https://github.com/cernekee/linux alps-v2

Tested on:

Dell E6410 (Pinnacle AGx) - E7/EC: 73 02 64 / 88 07 9d Dell E6230 (Rushmore without trackstick) - E7/EC: 73 03 0a / 88 08 1d Dell E6430 (Rushmore with trackstick) - E7/EC: 73 03 0a / 88 08 1d

Dolphin support is new and completely untested; if nobody reports success we should drop that patch. Also, there are at least two known Dolphin versions, which use different init sequences (at least in the Windows driver).

Commits:

Kevin Cernekee (14):
Input: ALPS - Document the alps.h data structures
Input: ALPS - Copy "model" info into alps_data struct
Input: ALPS - Move alps_get_model() down below hw_init code
Input: ALPS - Introduce helper function for repeated commands
Input: ALPS - Rework detection sequence
Input: ALPS - Use function pointers for different protocol handlers
Input: ALPS - Move {addr,nibble}_command settings into alps_set_defaults()
Input: ALPS - Rework detection of Pinnacle AGx touchpads
Input: ALPS - Fix command mode check
Input: ALPS - Move pixel and bitmap info into alps_data struct
Input: ALPS - Make the V3 packet field decoder "pluggable"
Input: ALPS - Add support for "Rushmore" touchpads
Input: ALPS - Enable trackstick on Rushmore touchpads
Input: ALPS - First attempt at "Dolphin" touchpad support