Input: ALPS - Clean up and rework driver to support newer touchpads
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest14 patches 3 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | Input: ALPS - Document the alps.h data structuresdrivers/ | +61 | 0 replies | |
| 2/14 | Input: ALPS - Copy "model" info into alps_data structdrivers/ drivers/ | +43 | 0 replies | |
| 3/14 | Input: ALPS - Move alps_get_model() down below hw_init codedrivers/ | +93 | 0 replies | |
| 4/14 | Input: ALPS - Introduce helper function for repeated commandsdrivers/ | +30 | 0 replies | |
| 5/14 | Input: ALPS - Rework detection sequencedrivers/ drivers/ | +56 | 0 replies | |
| 6/14 | Input: ALPS - Use function pointers for different protocol handlersdrivers/ drivers/ | +54 | 0 replies | |
| 7/14 | Input: ALPS - Move {addr,nibble}_command settings into alps_set_defaults()drivers/ | +4 | 0 replies | |
| 8/14 | Input: ALPS - Rework detection of Pinnacle AGx touchpadsdrivers/ | +12 | 0 replies | |
| 9/14 | Input: ALPS - Fix command mode checkdrivers/ | +1 | 0 replies | |
| 10/14 | Input: ALPS - Move pixel and bitmap info into alps_data structdrivers/ drivers/ | +33 | 0 replies | |
| 11/14 | Input: ALPS - Make the V3 packet field decoder "pluggable"drivers/ drivers/ | +95 | 0 replies | |
| 12/14 | Input: ALPS - Add support for "Rushmore" touchpadsdrivers/ | +52 | 0 replies | |
| 13/14 | Input: ALPS - Enable trackstick on Rushmore touchpadsdrivers/ | +115 | 0 replies | |
| 14/14 | Input: ALPS - First attempt at "Dolphin" touchpad supportdrivers/ drivers/ | +101 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH V2 00/14] Input: ALPS - Clean up and rework driver to support newer touchpads
Several modern ALPS devices require slight variations on existing driver functions. This patchset provides a way to "mix and match" various components, to avoid excessive code duplication and clutter:
- Separating the report format decoding from processing, so that Pinnacle AGx, Rushmore, and Dolphin touchpads can use a common processing function.
- Allowing devices with different register layouts to use the same processing functions but disparate init functions.
- Providing a way to discover touchpads like Pinnacle AGx and Rushmore, which are identified by a range of EC report values rather than an exact match to a specific E7 report sequence.
- Storing the bitmap and pixel constants in the alps_data struct, so they can be updated if the device uses different values (ala Dolphin).
V1->V2 changes with respect to Rushmore support:
- Fix MT and trackstick report decoding (credit to Emmanual Thome)
Baseline:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
git pull from:
https://github.com/cernekee/linux alps-v2
Tested on:
Dell E6410 (Pinnacle AGx) - E7/EC: 73 02 64 / 88 07 9d Dell E6230 (Rushmore without trackstick) - E7/EC: 73 03 0a / 88 08 1d Dell E6430 (Rushmore with trackstick) - E7/EC: 73 03 0a / 88 08 1d
Dolphin support is new and completely untested; if nobody reports success we should drop that patch. Also, there are at least two known Dolphin versions, which use different init sequences (at least in the Windows driver).
Commits:
Kevin Cernekee (14):
Input: ALPS - Document the alps.h data structures
Input: ALPS - Copy "model" info into alps_data struct
Input: ALPS - Move alps_get_model() down below hw_init code
Input: ALPS - Introduce helper function for repeated commands
Input: ALPS - Rework detection sequence
Input: ALPS - Use function pointers for different protocol handlers
Input: ALPS - Move {addr,nibble}_command settings into alps_set_defaults()
Input: ALPS - Rework detection of Pinnacle AGx touchpads
Input: ALPS - Fix command mode check
Input: ALPS - Move pixel and bitmap info into alps_data struct
Input: ALPS - Make the V3 packet field decoder "pluggable"
Input: ALPS - Add support for "Rushmore" touchpads
Input: ALPS - Enable trackstick on Rushmore touchpads
Input: ALPS - First attempt at "Dolphin" touchpad support