sco: SCO socket option for voice_setting
Get series with b4
b4 am 1376915043-24531-1-git-send-email-frederic.dalleau@linux.intel.comVersions newest first · linked by author and title
- v11 Latest10 patches 1 replyIn review
- v1010 patches 5 repliesSuperseded
- v99 patches 6 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 | 8 patches | 16 replies | Superseded | |
| v7 | 8 patches | 7 replies | Superseded | |
| v6 | 6 patches | 7 replies | Superseded | |
| v5 | 6 patches | 0 replies | Superseded | |
| v4 | 6 patches | 8 replies | Superseded | |
| v3 | 5 patches | 7 replies | Superseded |
Patches in v11 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | Bluetooth: Use hci_connect_sco directlyinclude/ net/ net/ | +5 | 0 replies | |
| 2/10 | Bluetooth: Remove unused mask parameter in sco_conn_defer_acceptnet/ | +3 | 0 replies | |
| 3/10 | Bluetooth: Add Bluetooth socket voice optioninclude/ include/ net/ | +48 | 0 replies | |
| 4/10 | Bluetooth: Add constants for SCO airmodeinclude/ | +4 | 0 replies | |
| 5/10 | Bluetooth: Use voice setting in deferred SCO connection requestnet/ | +17 | 0 replies | |
| 6/10 | Bluetooth: Parameters for outgoing SCO connectionsinclude/ net/ net/ | +23 | 0 replies | |
| 7/10 | Bluetooth: Add constants and macro declaration for transparent datainclude/ include/ | +2 | 0 replies | |
| 8/10 | Bluetooth: Prevent transparent SCO on older devicesnet/ | +6 | 0 replies | |
| 9/10 | Bluetooth: Handle specific error for SCO connection fallbacknet/ | +1 | 0 replies | |
| 10/10 | Bluetooth: Add SCO connection fallbackinclude/ net/ net/ | +40 | 1 reply |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Marcel Holtmann |
|---|---|
| 1/10 | A-b |
| 2/10 | A-b |
| 3/10 | A-b |
| 4/10 | A-b |
| 5/10 | A-b |
| 6/10 | A-b |
| 7/10 | A-b |
| 8/10 | A-b |
| 9/10 | A-b |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v11 00/10] sco: SCO socket option for voice_setting
Hi,
v11 uses bool instead of int in hci_setup_sync
v10 include contribution from Johan, he reworks fallback handling and fixes Marcel remarks from v9.
error 0x0d handling moved into a separate patch
v9 is mostly cosmetics. Introduces LMP_TRANSPARENT bit in patch 8/8.
v8 declares BT_VOICE_CVSD_16BIT
Merge T*, S* and D* patches in one
The last patch returns -ECONNABORTED when trying to setup a transparent data connection if eSCO is not supported.
v7 changes defaults to BT_VOICE_CVSD
Remove mask parameter to sco_conn_defer_accept, it was always 0 check the bits for air codec instead of use constants.
Add S3, S2, S1, D1, D0 settings.
The controller default is now only used to initialize the controller or fill in the missing information in case of using the old Add_SCO command
v6 fixes style issues
v5 changes interface to SOL_BLUETOOTH, BT_VOICE.
Rework fallback mechanism.
This is the patch version 4 of the socket option for enabling transparent SCO. As requested by Marcel, this is now a 16-bit voice_setting. 0x0000 is the value corresponding to current behavior.0x0003 is the value to use for enabling transparent data.
It is easy to allow all possible values from Bluetooth core spec, but I guess results can be unexpected...
Should we filter allowed values in setsockopt ?
Let me know what you think.
Regards,
Fred
Frédéric Dalleau (10):
Bluetooth: Use hci_connect_sco directly
Bluetooth: Remove unused mask parameter in sco_conn_defer_accept
Bluetooth: Add Bluetooth socket voice option
Bluetooth: Add constants for SCO airmode
Bluetooth: Use voice setting in deferred SCO connection request
Bluetooth: Parameters for outgoing SCO connections
Bluetooth: Add constants and macro declaration for transparent data
Bluetooth: Prevent transparent SCO on older devices
Bluetooth: Handle specific error for SCO connection fallback
Bluetooth: Add SCO connection fallback
include/net/bluetooth/bluetooth.h | 8 ++++ include/net/bluetooth/hci.h | 1 + include/net/bluetooth/hci_core.h | 10 ++++- include/net/bluetooth/sco.h | 1 + net/bluetooth/hci_conn.c | 62 +++++++++++++++++++++++------ net/bluetooth/hci_event.c | 7 ++-- net/bluetooth/sco.c | 77 ++++++++++++++++++++++++++++++------- 7 files changed, 137 insertions(+), 29 deletions(-)
Signature · 1 line
1.7.9.5