Skip to content

perf annotate: Add support for GTK+ annotation browser (v2)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 9 repliesIn review

v2 changes from the cover letter

* patch 1 and 2 in the previous patchset are merged already
* squash the last (add --gtk option) patch into the patch 1 (Arnaldo)
* make --gtk option does not fallback to stdio for a piped stdout (Borislav)

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf ui/gtk: Implement basic GTK2 annotation browsertools/perf/Documentation/perf-annotate.txt tools/perf/Makefile tools/perf/builtin-annotate.c +3 more+218 -41 reply
2/7perf gtk/annotate: Support multiple event annotationtools/perf/builtin-annotate.c tools/perf/ui/gtk/annotate.c tools/perf/ui/gtk/gtk.h +1 more+56 -271 reply
3/7perf gtk/annotate: Show source lines with gray colortools/perf/ui/gtk/annotate.c+27 -31 reply
4/7perf buildid-cache: Add --update optiontools/perf/Documentation/perf-buildid-cache.txt tools/perf/builtin-buildid-cache.c+53 -11 reply
5/7perf annotate: Fix warning message on a missing vmlinuxtools/perf/util/annotate.c+1 -11 reply
6/7perf gtk/annotate: Fail early if it can't annotatetools/perf/ui/gtk/annotate.c+8 -81 reply
7/7perf annotate: Make it to be able to skip unannotatable symbolstools/perf/builtin-annotate.c+15 -23 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] perf annotate: Add support for GTK+ annotation browser (v2)

Hi,

This patchset adds support to GTK+ annotation browser. For now only the most frequently sampled symbol per evsel will be shown. IOW it shows the hottest symbol per event by default and you can change it by giving the --symbol option or an argument.

The patch 4 and 5 are somewhat independent so that they can be merged separately.

You can also get it from my perf/annotate-gtk-v2 branch on

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks,
Namhyung

v2 changes:
* patch 1 and 2 in the previous patchset are merged already
* squash the last (add --gtk option) patch into the patch 1 (Arnaldo)
* make --gtk option does not fallback to stdio for a piped stdout (Borislav)

Namhyung Kim (7):
perf ui/gtk: Implement basic GTK2 annotation browser perf gtk/annotate: Support multiple event annotation perf gtk/annotate: Show source lines with gray color perf buildid-cache: Add --update option
perf annotate: Fix warning message on a missing vmlinux perf gtk/annotate: Fail early if it can't annotate perf annotate: Make it to be able to skip unannotatable symbols

 tools/perf/Documentation/perf-annotate.txt      |   4 +-
 tools/perf/Documentation/perf-buildid-cache.txt |   4 +
 tools/perf/Makefile                             |   1 +
 tools/perf/builtin-annotate.c                   |  27 ++-
 tools/perf/builtin-buildid-cache.c              |  50 +++++-
 tools/perf/ui/gtk/annotate.c                    | 229 ++++++++++++++++++++++++
 tools/perf/ui/gtk/gtk.h                         |   1 +
 tools/perf/ui/setup.c                           |   2 +-
 tools/perf/util/annotate.c                      |   2 +-
 tools/perf/util/annotate.h                      |  24 +++
 10 files changed, 338 insertions(+), 6 deletions(-)
 create mode 100644 tools/perf/ui/gtk/annotate.c
Signature · 1 line
1.7.11.7