Skip to content

Error reporting fixes

Markus Armbruster qemu-trivial 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 16 repliesIn review
  2. v16 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* Clean up messages touched by PATCH 01 some more (Peter Maydell)
* The other patches are unchanged

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6error: Clean up error strings with embedded newlineshw/kvm/pci-assign.c+6 -65 replies
2/6error: Clean up abuse of error_report() for helphw/vfio_pci.c+2 -20 replies
3/6error: Strip trailing '\n' from error string arguments (again)block/gluster.c hmp.c hw/9pfs/virtio-9p-proxy.c +13 more+83 -831 reply
4/6qemu-option: Disable two helpful messages that got broken recentlyutil/qemu-option.c+4 -05 replies
5/6vl: Drop redundant "parse error" reportsvl.c+0 -41 reply
6/6vl: Exit unsuccessfully on option argument syntax errorvl.c+8 -22 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchLuiz Capitulino
1/6
2/6
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-trivial] [PATCH for-1.4 v2 0/6] Error reporting fixes

I tagged this for 1.4 because the patches improve the user experience a bit, and are all low risk.

v2:
* Clean up messages touched by PATCH 01 some more (Peter Maydell)
* The other patches are unchanged

Markus Armbruster (6):
error: Clean up error strings with embedded newlines
error: Clean up abuse of error_report() for help
error: Strip trailing '\n' from error string arguments (again)
qemu-option: Disable two helpful messages that got broken recently
vl: Drop redundant "parse error" reports
vl: Exit unsuccessfully on option argument syntax error

 block/gluster.c             |   2 +-
 hmp.c                       |   2 +-
 hw/9pfs/virtio-9p-proxy.c   |   2 +-
 hw/kvm/pci-assign.c         |  12 ++---
 hw/pci/pci.c                |   2 +-
 hw/qdev.c                   |   4 +-
 hw/qxl.c                    |   2 +-
 hw/vfio_pci.c               | 114 ++++++++++++++++++++++----------------------
 hw/vhost_net.c              |   4 +-
 migration.c                 |   2 +-
 qemu-char.c                 |   8 ++--
 target-i386/cpu.c           |  10 ++--
 target-ppc/translate_init.c |   2 +-
 ui/console.c                |   2 +-
 ui/input.c                  |   2 +-
 util/qemu-config.c          |   6 +--
 util/qemu-option.c          |   4 ++
 util/qemu-sockets.c         |   6 +--
 vl.c                        |  14 +++---
 19 files changed, 103 insertions(+), 97 deletions(-)
Signature · 1 line
1.7.11.7