Skip to content

memcg targeted shrinking

Glauber Costa cgroups linux-fsdevel linux-mm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7vmscan: also shrink slab in memcg pressureinclude/linux/memcontrol.h include/linux/shrinker.h mm/memcontrol.c +1 more+68 -44 replies
2/7memcg,list_lru: duplicate LRUs upon kmemcg creationinclude/linux/list_lru.h include/linux/memcontrol.h lib/list_lru.c +2 more+283 -145 replies
3/7lru: add an element to a memcg listinclude/linux/list_lru.h include/linux/memcontrol.h lib/list_lru.c +1 more+105 -82 replies
4/7list_lru: also include memcg lists in counts and scansinclude/linux/memcontrol.h lib/list_lru.c+69 -230 replies
5/7list_lru: per-memcg walksinclude/linux/list_lru.h lib/list_lru.c+52 -130 replies
6/7super: targeted memcg reclaimfs/dcache.c fs/inode.c fs/internal.h +1 more+37 -180 replies
7/7memcg: per-memcg kmem shrinkinginclude/linux/swap.h mm/memcontrol.c mm/vmscan.c+137 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] memcg targeted shrinking

This patchset implements targeted shrinking for memcg when kmem limits are present. So far, we've been accounting kernel objects but failing allocations when short of memory. This is because our only option would be to call the global shrinker, depleting objects from all caches and breaking isolation.

This patchset builds upon the recent work from David Chinner
(http://oss.sgi.com/archives/xfs/2012-11/msg00643.html) to implement NUMA aware per-node LRUs. I build heavily on its API, and its presence is implied.

The main idea is to associate per-memcg lists with each of the LRUs. The main LRU still provides a single entry point and when adding or removing an element from the LRU, we use the page information to figure out which memcg it belongs to and relay it to the right list.

This patchset is still not perfect, and some uses cases still need to be dealt with. But I wanted to get this out in the open sooner rather than later. In particular, I have the following (noncomprehensive) todo list:

TODO:
* shrink dead memcgs when global pressure kicks in.
* balance global reclaim among memcgs.
* improve testing and reliability (I am still seeing some stalls in some cases)

Glauber Costa (7):
vmscan: also shrink slab in memcg pressure memcg,list_lru: duplicate LRUs upon kmemcg creation
lru: add an element to a memcg list
list_lru: also include memcg lists in counts and scans
list_lru: per-memcg walks
super: targeted memcg reclaim
memcg: per-memcg kmem shrinking

 fs/dcache.c                |   7 +-
 fs/inode.c                 |   6 +-
 fs/internal.h              |   5 +-
 fs/super.c                 |  37 ++++--
 include/linux/list_lru.h   |  81 +++++++++++-
 include/linux/memcontrol.h |  34 +++++
 include/linux/shrinker.h   |   4 +
 include/linux/swap.h       |   2 +
 lib/list_lru.c             | 301 ++++++++++++++++++++++++++++++++++++++-------
 mm/memcontrol.c            | 271 ++++++++++++++++++++++++++++++++++++++--
 mm/slab_common.c           |   1 -
 mm/vmscan.c                |  78 +++++++++++-
 12 files changed, 747 insertions(+), 80 deletions(-)
Signature · 1 line
1.8.1