Skip to content

hid driver transport cleanup

Benjamin Tissoires linux-input lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 5 repliesIn review
  2. v17 patches 16 repliesSuperseded

Changes in v2 from the cover letter

- gathered reviewed/acked/etc..
- changed commit messages of patches 4-6
- add newcomer into account (thingm)
- incorporated the i2c-hid driver change into the series

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8HID: Extend the interface with report requestsdrivers/hid/usbhid/hid-core.c include/linux/hid.h+33 -00 replies
2/8HID: Extend the interface with wait io requestdrivers/hid/usbhid/hid-core.c include/linux/hid.h+15 -00 replies
3/8HID: Kconfig: Remove explicit transport layer dependenciesdrivers/hid/Kconfig drivers/hid/hid-apple.c drivers/hid/hid-magicmouse.c +2 more+34 -390 replies
4/8HID: use hid_hw_request() instead of direct call to usbhiddrivers/hid/Kconfig drivers/hid/hid-axff.c drivers/hid/hid-dr.c +31 more+111 -1570 replies
5/8HID: use hid_hw_wait() instead of direct call to usbhiddrivers/hid/Kconfig drivers/hid/hid-ntrig.c drivers/hid/hid-picolcd_fb.c +5 more+18 -220 replies
6/8HID: multitouch: remove explicit usbhid dependencydrivers/hid/hid-multitouch.c+1 -20 replies
7/8HID: multitouch: Copyright and note on regression testsdrivers/hid/hid-multitouch.c+13 -10 replies
8/8HID: i2c-hid: implement request() callbackdrivers/hid/i2c-hid/i2c-hid.c+32 -00 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchMika WesterbergHenrik Rydberg
1/8R-b
2/8R-b
3/8R-b A-b
4/8R-b T-b
5/8R-b
6/8R-b
7/8R-b A-b
8/8T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] hid driver transport cleanup

Hi guys,

this is the v2 of the hid transport cleanup.

Changes since v1:
- gathered reviewed/acked/etc..
- changed commit messages of patches 4-6
- add newcomer into account (thingm)
- incorporated the i2c-hid driver change into the series

I still did not implemented the final usb cleanup for hid-multitouch as it may required few comments.

Cheers,
Benjamin

Benjamin Tissoires (8):
HID: Extend the interface with report requests
HID: Extend the interface with wait io request
HID: Kconfig: Remove explicit transport layer dependencies
HID: use hid_hw_request() instead of direct call to usbhid
HID: use hid_hw_wait() instead of direct call to usbhid
HID: multitouch: remove explicit usbhid dependency
HID: multitouch: Copyright and note on regression tests
HID: i2c-hid: implement request() callback

 drivers/hid/Kconfig                 | 100 ++++++++++++++++++------------------
 drivers/hid/hid-apple.c             |   1 -
 drivers/hid/hid-axff.c              |   6 +--
 drivers/hid/hid-dr.c                |   8 ++-
 drivers/hid/hid-emsff.c             |   6 +--
 drivers/hid/hid-gaff.c              |  10 ++--
 drivers/hid/hid-holtekff.c          |   4 +-
 drivers/hid/hid-kye.c               |   4 +-
 drivers/hid/hid-lenovo-tpkbd.c      |   4 +-
 drivers/hid/hid-lg2ff.c             |   6 +--
 drivers/hid/hid-lg3ff.c             |   6 +--
 drivers/hid/hid-lg4ff.c             |  18 +++----
 drivers/hid/hid-lgff.c              |   8 ++-
 drivers/hid/hid-logitech-dj.c       |   3 +-
 drivers/hid/hid-magicmouse.c        |   1 -
 drivers/hid/hid-multitouch.c        |  21 ++++++--
 drivers/hid/hid-ntrig.c             |  10 ++--
 drivers/hid/hid-picolcd.h           |   4 +-
 drivers/hid/hid-picolcd_backlight.c |   4 +-
 drivers/hid/hid-picolcd_cir.c       |   2 -
 drivers/hid/hid-picolcd_core.c      |   8 ++-
 drivers/hid/hid-picolcd_debugfs.c   |   2 -
 drivers/hid/hid-picolcd_fb.c        |  12 ++---
 drivers/hid/hid-picolcd_lcd.c       |   4 +-
 drivers/hid/hid-picolcd_leds.c      |   4 +-
 drivers/hid/hid-pl.c                |   6 +--
 drivers/hid/hid-prodikeys.c         |   3 +-
 drivers/hid/hid-sensor-hub.c        |  12 ++---
 drivers/hid/hid-sjoy.c              |   6 +--
 drivers/hid/hid-speedlink.c         |   2 -
 drivers/hid/hid-steelseries.c       |   3 +-
 drivers/hid/hid-thingm.c            |   1 -
 drivers/hid/hid-tmff.c              |   6 +--
 drivers/hid/hid-zpff.c              |   6 +--
 drivers/hid/i2c-hid/i2c-hid.c       |  32 ++++++++++++
 drivers/hid/usbhid/hid-core.c       |  20 ++++++--
 drivers/hid/usbhid/hid-pidff.c      |  80 ++++++++++++++---------------
 drivers/hid/usbhid/hiddev.c         |   8 +--
 drivers/hid/usbhid/usbhid.h         |   3 --
 include/linux/hid.h                 |  34 ++++++++++++
 40 files changed, 257 insertions(+), 221 deletions(-)
Signature · 1 line
1.8.1.2