Skip to content

brcmfmac: add initial (old-school) P2P support

Arend van Spriel linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest27 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27brcmfmac: add peer-to-peer group discovery supportdrivers/net/wireless/brcm80211/brcmfmac/Makefile drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/p2p.c +3 more+1078 -510 replies
2/27brcmfmac: add support for creating P2P client/GO interfacedrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/fwil_types.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c +2 more+289 -150 replies
3/27brcmfmac: add support for P2P listen mode.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/fweh.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c +3 more+341 -340 replies
4/27brcmfmac: fix compiler warning on printf formatdrivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+1 -10 replies
5/27brcmfmac: fix generation of the p2p related mac addressesdrivers/net/wireless/brcm80211/brcmfmac/p2p.c+1 -30 replies
6/27brcmfmac: implement support for deleting virtual interfacesdrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c +1 more+176 -920 replies
7/27brcmfmac: update escan for multiple bss and simplify.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+19 -840 replies
8/27brcmfmac: update p2p add and delete vif routines.drivers/net/wireless/brcm80211/brcmfmac/fwil_types.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c+25 -100 replies
9/27brcmfmac: add p2p change vif routines.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h +2 more+119 -170 replies
10/27brcmfmac: Fix bug mgmt_rx_registerdrivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+1 -10 replies
11/27brcmfmac: Update connect setup/handling routines for multiple bss.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h+258 -1320 replies
12/27brcmfmac: Update AP mode for GO creation.drivers/net/wireless/brcm80211/brcmfmac/fwil_types.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h +1 more+183 -860 replies
13/27brcmfmac: Add handling of receiving P2P action frames.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+350 -00 replies
14/27brcmfmac: P2P action frame tx.drivers/net/wireless/brcm80211/brcmfmac/fwil_types.h drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h +2 more+361 -40 replies
15/27brcmfmac: Use real cookie value for p2p remain on channel.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h+51 -160 replies
16/27brcmfmac: change function signaturesdrivers/net/wireless/brcm80211/brcmfmac/p2p.c+1 -10 replies
17/27brcmfmac: Create p2p0 netdev via module variable.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h +1 more+213 -1400 replies
18/27brcmfmac: Use role from wdev on AP commands and fix stop_ap.drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+14 -370 replies
19/27brcmfmac: Put printing action frames code under debug flag.drivers/net/wireless/brcm80211/brcmfmac/p2p.c+11 -00 replies
20/27brcmfmac: Ignore E_ADD_IF for ifidx 0.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+1 -10 replies
21/27brcmfmac: Reject change vif for p2p if.drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+12 -00 replies
22/27brcmfmac: Update netdev configuration in wiphy for p2p.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+9 -40 replies
23/27brcmfmac: Remove sleep on del_station.drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+1 -60 replies
24/27brcmfmac: Fix rtnl_lock lockup when registering netdev.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fweh.c +1 more+11 -60 replies
25/27brcmfmac: Cleanup of unused defines.drivers/net/wireless/brcm80211/brcmfmac/p2p.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h+1 -70 replies
26/27brcmfmac: Create netdev before returning from add_virtual_intf.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h+6 -120 replies
27/27brcmfmac: Add tx p2p off-channel support.drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/brcm80211/brcmfmac/p2p.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+707 -930 replies

Reviews trailers per patch

26 of 27 patches have a Reviewed-by or Acked-by.

PatchPieter-Paul GiesbertsHante MeulemanArend Van SprielFranky (Zhenhui) LinPiotr Haber
1/27R-b R-b
2/27R-b R-b R-b
3/27R-b R-b
4/27R-b
5/27R-b R-b
6/27R-b R-b
7/27R-b R-b
8/27R-b R-b
9/27R-b R-b
10/27R-b R-b
11/27R-b R-b
12/27R-b R-b
13/27R-b R-b
14/27R-b R-b
15/27R-b R-b
16/27
17/27R-b R-b
18/27R-b
19/27R-b
20/27R-b
21/27R-b R-b
22/27R-b R-b R-b
23/27R-b R-b R-b
24/27R-b R-b R-b
25/27R-b
26/27R-b R-b R-b
27/27R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/27] brcmfmac: add initial (old-school) P2P support

This series adds P2P functionality to the brcmfmac driver. It has been verified with wpa_supplicant performing successful FIND, LISTEN and GO Negotiation. It can setup a peer-to-peer connection while associated with an AP.

Now for the term "old-school". While working on this feature the nl80211 interface type P2P_DEVICE was introduced. However, wpa_supplicant has not support for it so the feature was developed and tested using a dummy net device for P2P management. We have had contact with David Spinadel, who is doing the wpa_supplicant work. Our next step will be to rework brcmfmac supporting the P2P_DEVICE type and test it against wpa_supplicant with David's changes.

Using the patches in this series, people can have a look at P2P feature when it is built with CONFIG_BRCMDBG and the module is loaded with the parameter p2pon=1.

This series is intended for v3.9 and depends on the patch series identified by:

<[email protected]>

Arend van Spriel (6):
brcmfmac: add peer-to-peer group discovery support
brcmfmac: add support for creating P2P client/GO interface
brcmfmac: fix compiler warning on printf format
brcmfmac: fix generation of the p2p related mac addresses
brcmfmac: implement support for deleting virtual interfaces
brcmfmac: change function signatures

Hante Meuleman (21):
brcmfmac: add support for P2P listen mode.
brcmfmac: update escan for multiple bss and simplify.
brcmfmac: update p2p add and delete vif routines.
brcmfmac: add p2p change vif routines.
brcmfmac: Fix bug mgmt_rx_register
brcmfmac: Update connect setup/handling routines for multiple bss.
brcmfmac: Update AP mode for GO creation.
brcmfmac: Add handling of receiving P2P action frames.
brcmfmac: P2P action frame tx.
brcmfmac: Use real cookie value for p2p remain on channel.
brcmfmac: Create p2p0 netdev via module variable.
brcmfmac: Use role from wdev on AP commands and fix stop_ap.
brcmfmac: Put printing action frames code under debug flag.
brcmfmac: Ignore E_ADD_IF for ifidx 0.
brcmfmac: Reject change vif for p2p if.
brcmfmac: Update netdev configuration in wiphy for p2p.
brcmfmac: Remove sleep on del_station.
brcmfmac: Fix rtnl_lock lockup when registering netdev.
brcmfmac: Cleanup of unused defines.
brcmfmac: Create netdev before returning from add_virtual_intf.
brcmfmac: Add tx p2p off-channel support.

 drivers/net/wireless/brcm80211/brcmfmac/Makefile   |    3 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |   39 +-
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |  124 +-
 drivers/net/wireless/brcm80211/brcmfmac/fweh.c     |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/fweh.h     |    6 +-
 .../net/wireless/brcm80211/brcmfmac/fwil_types.h   |   66 +
 drivers/net/wireless/brcm80211/brcmfmac/p2p.c      | 2277 ++++++++++++++++++++
 drivers/net/wireless/brcm80211/brcmfmac/p2p.h      |  183 ++
 .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c  | 1262 ++++++++---
 .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.h  |  113 +-
 10 files changed, 3731 insertions(+), 344 deletions(-)
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/fwil_types.h
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/p2p.c
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/p2p.h
Signature · 1 line
1.7.10.4