Skip to content

x86, head_32: Some cleanups

Borislav Petkov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86, head_32: Remove i386 piecesarch/x86/kernel/head_32.S+5 -171 reply
2/4x86: Detect CPUID support early at bootarch/x86/kernel/head_32.S+25 -251 reply
3/4x86, head_32: Remove second CPUID detection from default_entryarch/x86/kernel/head_32.S+4 -134 replies
4/4x86, head_32: Give the 6 label a real namearch/x86/kernel/head_32.S+6 -61 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4 -v3] x86, head_32: Some cleanups

From: Borislav Petkov <[email protected]>

Hi,

this is the new version with patch 5 from the old transformed into an expanded, more verbose comment at the beginning of default_entry. No changes otherwise.

Changelog:

v2:

Here's the next version with new_cpu_data left put and two minor fixlets added at the end. The patchset was boot-tested on a bunch of baremetal boxes and all QEMU cpu models - no issues.

Boot tests:

* baremetal:
- P4
- Atom n270
- 32-bit kernel on an AMD64 (F10h Phenom and Intel SNB)

* qemu, with cpu models:
- qemu64
- phenom
- core2duo
- kvm64
- qemu32
- kvm32
- coreduo
- 486{,SX}
- pentium{,2,3}
- athlon
- n270,+movbe
- Conroe
- Penryn
- Nehalem
- Westmere
- SandyBridge
- Haswell
- Opteron_G{1,2,3,4,5}

Why am I testing all those, you ask? Because I'm a sadistic mofo :-)

v1:

here are some initial low-hanging fruits wrt head_32.S cleanup. I've made them as easily digestible as possible; after all, this is boot asm and meddling with it tends to upset kernels.

Also, I've made the assumption that having boot_cpu_data.cpuid_level contain the CPUID level for the boot cpu means that the APs have the same CPUID level. This should be the case on X86.

They boot fine 486 and 486SX in qemu but I'd like to hear whether the direction I'm going is ok before I continue testing them on real hardware.

Borislav Petkov (4):
x86, head_32: Remove i386 pieces
x86: Detect CPUID support early at boot
x86, head_32: Remove second CPUID detection from default_entry x86, head_32: Give the 6 label a real name

 arch/x86/kernel/head_32.S | 93 ++++++++++++++++++-----------------------------
 1 file changed, 36 insertions(+), 57 deletions(-)
Signature · 1 line
1.8.1.3.535.ga923c31