Skip to content

em28xx: add image quality bridge controls

Frank Schäfer linux-media 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 0 repliesNew
  2. v14 patches 1 replySuperseded

Changes in v2 from the cover letter

- fixed a tab-space issue in patch 3

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4em28xx: remove unused image quality control functionsdrivers/media/usb/em28xx/em28xx.h+0 -660 replies
2/4em28xx: remove unused ac97 v4l2_ctrl_handlerdrivers/media/usb/em28xx/em28xx.h+0 -20 replies
3/4em28xx: introduce #defines for the image quality default settingsdrivers/media/usb/em28xx/em28xx-core.c drivers/media/usb/em28xx/em28xx-reg.h+23 -120 replies
4/4em28xx: add image quality bridge controlsdrivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-video.c+57 -80 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchHans Verkuil
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] em28xx: add image quality bridge controls

The first two patches remove unused code.
The third patch makes sure that the same image quality default settings are used everywhere in the code.
The fourth patch finally adds the following image quality bridge controls:
- contrast
- brightness
- saturation
- blue balance
- red balance
- sharpness

Tested with the following devices:
"Terratec Cinergy 200 USB"
"Hauppauge HVR-900"
"SilverCrest 1.3MPix webcam"
"Hauppauge WinTV USB2"
"Speedlink VAD Laplace webcam"

Changes in v2:
- fixed a tab-space issue in patch 3

Frank Schäfer (4):
em28xx: remove unused image quality control functions
em28xx: remove unused ac97 v4l2_ctrl_handler
em28xx: introduce #defines for the image quality default settings
em28xx: add image quality bridge controls

 drivers/media/usb/em28xx/em28xx-cards.c |    7 +---
 drivers/media/usb/em28xx/em28xx-core.c  |   12 +++---
 drivers/media/usb/em28xx/em28xx-reg.h   |   23 ++++++++---
 drivers/media/usb/em28xx/em28xx-video.c |   58 +++++++++++++++++++++++++-
 drivers/media/usb/em28xx/em28xx.h       |   68 -------------------------------

5 Dateien geändert, 80 Zeilen hinzugefügt(+), 88 Zeilen entfernt(-)

Signature · 1 line
1.7.10.4