Skip to content

gpiolib: some fixup patches

Alexandre Courbot linux-gpio linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4gpiolib: check descriptors validity before usedrivers/gpio/gpiolib.c+35 -292 replies
2/4gpiolib: use const parameters when possibledrivers/gpio/gpiolib.c+16 -139 replies
3/4gpiolib: move comment to right functiondrivers/gpio/gpiolib.c+1 -10 replies
4/4gpiolib: rename local offset variables to "hwgpio"drivers/gpio/gpiolib.c+35 -352 replies
4/4gpiolib: rename local offset variables to "hwgpio"drivers/gpio/gpiolib.c+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] gpiolib: some fixup patches

This short series is a fixup to patch 6/9 of my previous series ("gpiolib: use descriptors internally"), which mainly addresses issues raised by Linus W. in this patch and a few other minor ones caught while proof-reading gpiolib.

First patch is the most significant. It mostly avoids oopses when passing an invalid GPIO to some functions. Also gpio_get/set_value*() now return 0 when given an invalid GPIO number instead of oopsing. I tend to think that's an improvement, but if it's not please let me know.

Ideally these patches should be melded into the above-mentioned patch since they were intended to become a new revision, but I leave that decision to Grant's discretion.

This patchset has been thoroughly tested on Tegra 2/Ventana with a GPIO backlight driver and the sysfs interface.

Alexandre Courbot (4):
gpiolib: check descriptors validity before use
gpiolib: use const parameters when possible
gpiolib: move comment to right function
gpiolib: rename local offset variables to "hwgpio"

 drivers/gpio/gpiolib.c | 165 ++++++++++++++++++++++++++-----------------------
 1 file changed, 87 insertions(+), 78 deletions(-)
Signature · 1 line
1.8.1.3