Skip to content

Block cleanups - prep work for immutable bio vecs/dio rewrite

Kent Overstreet dm-devel drbd-dev linux-s390 linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest27 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27block: Reorder struct bio_setinclude/linux/bio.h+33 -330 replies
2/27block: Avoid deadlocks with bio allocation by stacking driversfs/bio.c include/linux/bio.h+123 -20 replies
3/27block: Fix a buffer overrun in bio_integrity_split()fs/bio-integrity.c include/linux/bio.h+6 -30 replies
4/27block: Convert integrity to bvec_alloc_bs()fs/bio-integrity.c fs/bio.c include/linux/bio.h+68 -1081 reply
5/27block: Add bio_advance()fs/bio.c include/linux/bio.h include/linux/blk_types.h+45 -00 replies
6/27block: Refactor blk_update_request()block/blk-core.c+12 -680 replies
7/27md: Convert md_trim_bio() to use bio_advance()drivers/md/md.c+4 -130 replies
8/27block: Add bio_end_sector()block/blk-core.c block/cfq-iosched.c block/deadline-iosched.c +12 more+26 -340 replies
9/27block: Use bio_sectors() more consistentlydrivers/block/pktcdvd.c drivers/md/dm-raid1.c drivers/md/raid0.c +5 more+35 -381 reply
10/27block: Change bio_split() to respect the current value of bi_idxdrivers/md/raid0.c drivers/md/raid10.c fs/bio-integrity.c +1 more+7 -100 replies
11/27block: Remove bi_idx referencesdrivers/block/aoe/aoecmd.c drivers/block/floppy.c drivers/md/dm-verity.c +5 more+2 -130 replies
12/27block: Remove some unnecessary bi_vcnt usagedrivers/message/fusion/mptsas.c drivers/scsi/libsas/sas_expander.c drivers/scsi/mpt2sas/mpt2sas_transport.c+11 -110 replies
13/27block: Add submit_bio_wait(), remove from mddrivers/md/raid1.c drivers/md/raid10.c fs/bio.c +1 more+37 -380 replies
14/27raid10: Use bio_reset()drivers/md/raid10.c+9 -220 replies
15/27raid1: use bio_reset()drivers/md/raid1.c+6 -180 replies
16/27raid5: use bio_reset()drivers/md/raid5.c+13 -140 replies
17/27raid1: Refactor narrow_write_error() to not use bi_idxdrivers/md/raid1.c+18 -180 replies
18/27block: Add bio_copy_data()fs/bio.c include/linux/bio.h+72 -00 replies
19/27pktcdvd: use bio_copy_data()drivers/block/pktcdvd.c+12 -670 replies
20/27pktcdvd: Use bio_reset() in disabled code to kill bi_idx usagedrivers/block/pktcdvd.c+8 -90 replies
21/27raid1: use bio_copy_data()drivers/md/raid1.c+2 -30 replies
22/27bounce: Refactor __blk_queue_bounce to not use bi_io_vecmm/bounce.c+19 -540 replies
23/27block: Add bio_for_each_segment_all()drivers/block/rbd.c drivers/md/raid1.c fs/bio.c +4 more+25 -140 replies
24/27block: Convert some code to bio_for_each_segment_all()drivers/md/dm-crypt.c drivers/md/raid1.c fs/bio.c +2 more+19 -240 replies
25/27block: Add bio_alloc_pages()drivers/md/raid1.c fs/bio.c include/linux/bio.h+32 -130 replies
26/27block: Add an explicit bio flag for bios that own their bvecfs/bio.c include/linux/bio.h include/linux/blk_types.h+4 -62 replies
27/27bio-integrity: Add explicit field for owner of bip_buffs/bio-integrity.c include/linux/bio.h+3 -30 replies

Reviews trailers per patch

7 of 27 patches have a Reviewed-by or Acked-by.

PatchSteven WhitehouseEd CashinTejun HeoMuthukumar RattyNeilBrown
1/27
2/27A-b R-b
3/27
4/27
5/27
6/27
7/27A-b
8/27A-b
9/27A-b
10/27
11/27
12/27
13/27A-b
14/27A-b
15/27
16/27
17/27
18/27
19/27
20/27
21/27
22/27
23/27
24/27
25/27
26/27A-b
27/27

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/27] Block cleanups - prep work for immutable bio vecs/dio rewrite

Jens - this is the patch series I was working on a couple months ago, and then got sidetracked on.

I rebased it onto your for-3.9/core branch. Nothing's changed (besides a few random merge conflicts) since the last time I mailed it out - I think all this stuff is ready.

Kent Overstreet (27):
block: Reorder struct bio_set
block: Avoid deadlocks with bio allocation by stacking drivers
block: Fix a buffer overrun in bio_integrity_split()
block: Convert integrity to bvec_alloc_bs()
block: Add bio_advance()
block: Refactor blk_update_request()
md: Convert md_trim_bio() to use bio_advance()
block: Add bio_end_sector()
block: Use bio_sectors() more consistently
block: Change bio_split() to respect the current value of bi_idx
block: Remove bi_idx references
block: Remove some unnecessary bi_vcnt usage
block: Add submit_bio_wait(), remove from md
raid10: Use bio_reset()
raid1: use bio_reset()
raid5: use bio_reset()
raid1: Refactor narrow_write_error() to not use bi_idx
block: Add bio_copy_data()
pktcdvd: use bio_copy_data()
pktcdvd: Use bio_reset() in disabled code to kill bi_idx usage
raid1: use bio_copy_data()
bounce: Refactor __blk_queue_bounce to not use bi_io_vec
block: Add bio_for_each_segment_all()
block: Convert some code to bio_for_each_segment_all()
block: Add bio_alloc_pages()
block: Add an explicit bio flag for bios that own their bvec
bio-integrity: Add explicit field for owner of bip_buf

 block/blk-core.c                         |  82 ++-----
 block/cfq-iosched.c                      |   7 +-
 block/deadline-iosched.c                 |   2 +-
 drivers/block/aoe/aoecmd.c               |   2 +-
 drivers/block/brd.c                      |   3 +-
 drivers/block/floppy.c                   |   1 -
 drivers/block/pktcdvd.c                  | 102 ++-------
 drivers/block/rbd.c                      |   2 +-
 drivers/md/dm-crypt.c                    |   3 +-
 drivers/md/dm-raid1.c                    |   2 +-
 drivers/md/dm-stripe.c                   |   2 +-
 drivers/md/dm-verity.c                   |   4 +-
 drivers/md/faulty.c                      |   6 +-
 drivers/md/linear.c                      |   3 +-
 drivers/md/md.c                          |  17 +-
 drivers/md/raid0.c                       |   9 +-
 drivers/md/raid1.c                       | 133 ++++-------
 drivers/md/raid10.c                      |  78 ++-----
 drivers/md/raid5.c                       |  49 ++---
 drivers/message/fusion/mptsas.c          |   6 +-
 drivers/s390/block/dcssblk.c             |   3 +-
 drivers/scsi/libsas/sas_expander.c       |   6 +-
 drivers/scsi/mpt2sas/mpt2sas_transport.c |  10 +-
 fs/bio-integrity.c                       | 144 +++++-------
 fs/bio.c                                 | 366 +++++++++++++++++++++++++++----
 fs/btrfs/extent_io.c                     |   3 +-
 fs/btrfs/volumes.c                       |   2 +-
 fs/buffer.c                              |   1 -
 fs/direct-io.c                           |   8 +-
 fs/exofs/ore.c                           |   2 +-
 fs/exofs/ore_raid.c                      |   2 +-
 fs/gfs2/lops.c                           |   2 +-
 fs/jfs/jfs_logmgr.c                      |   2 -
 fs/logfs/dev_bdev.c                      |   5 -
 include/linux/bio.h                      | 115 ++++++----
 include/linux/blk_types.h                |   3 +
 include/trace/events/block.h             |  12 +-
 mm/bounce.c                              |  75 ++-----
 mm/page_io.c                             |   1 -
 39 files changed, 645 insertions(+), 630 deletions(-)
Signature · 1 line
1.7.12