Skip to content

perf: A tools library

Borislav Petkov lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf, debugfs: Remove a write-only variabletools/perf/util/debugfs.c+5 -80 replies
2/7perf: Honor parallel jobsMakefile tools/scripts/Makefile.include+3 -30 replies
3/7perf: Correct Makefile.includetools/scripts/Makefile.include+3 -10 replies
4/7perf: Carve out debugfstools/Makefile tools/lib/lk/Makefile tools/lib/lk/debugfs.c +14 more+131 -400 replies
5/7perf: Extract perf-specific stuff from debugfs.ctools/lib/lk/debugfs.c tools/lib/lk/debugfs.h tools/perf/perf.c +3 more+36 -230 replies
6/7perf: Do not allow empty debugfs-dir optiontools/perf/perf.c+4 -00 replies
7/7tools/vm: Switch to liblk librarytools/vm/Makefile tools/vm/page-types.c+21 -810 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] perf: A tools library

From: Borislav Petkov <[email protected]>

Hi,

so this is a pretty old intention which I had put on the backburner due to work-related stuff but here it is again. Basically we want to carve out stuff in tools/ which is generic enough to be shared between the different tools instead of replicating it among them.

And this is a first go at sharing the debugfs searching and setting code between perf and vm/page-types.c which had an older debugfs_mount et. al. version.

Please take a look at let me know whether the direction is ok. It builds and works fine here but I could've missed something so consider this RFC-ish of nature.

Thanks.

Borislav Petkov (7):
perf, debugfs: Remove a write-only variable
perf: Honor parallel jobs
perf: Correct Makefile.include
perf: Carve out debugfs
perf: Extract perf-specific stuff from debugfs.c
perf: Do not allow empty debugfs-dir option tools/vm: Switch to liblk library

 Makefile                              |  4 +-
 tools/Makefile                        | 16 ++++++-
 tools/lib/lk/Makefile                 | 35 +++++++++++++++
 tools/{perf/util => lib/lk}/debugfs.c | 49 ++++++++------------
 tools/lib/lk/debugfs.h                | 29 ++++++++++++
 tools/perf/Makefile                   | 34 +++++++++++---
 tools/perf/builtin-kvm.c              |  2 +-
 tools/perf/builtin-probe.c            |  2 +-
 tools/perf/perf.c                     | 12 +++--
 tools/perf/tests/parse-events.c       |  2 +-
 tools/perf/util/debugfs.h             | 12 -----
 tools/perf/util/evlist.c              |  2 +-
 tools/perf/util/evsel.c               |  2 +-
 tools/perf/util/parse-events.c        |  2 +-
 tools/perf/util/probe-event.c         |  2 +-
 tools/perf/util/python-ext-sources    |  1 -
 tools/perf/util/setup.py              |  3 +-
 tools/perf/util/trace-event-info.c    |  4 +-
 tools/perf/util/util.c                | 27 +++++++++++
 tools/perf/util/util.h                |  7 ++-
 tools/scripts/Makefile.include        |  6 ++-
 tools/vm/Makefile                     | 17 +++++--
 tools/vm/page-types.c                 | 85 +++--------------------------------
 23 files changed, 201 insertions(+), 154 deletions(-)
 create mode 100644 tools/lib/lk/Makefile
 rename tools/{perf/util => lib/lk}/debugfs.c (68%)
 create mode 100644 tools/lib/lk/debugfs.h
 delete mode 100644 tools/perf/util/debugfs.h
Signature · 1 line
1.8.1.3.535.ga923c31