Skip to content

TTY: port hangup and close fixes

Johan Hovold linux-serial 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 4 patches 1 replyIn review

1 of 4 patches is in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/4TTY: fix close of uninitialised portsdrivers/tty/tty_port.c+10 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] TTY: port hangup and close fixes

These patches against tty-next fix a few issues with tty-port hangup and close.

The first and third patch are essentially clean ups.

The second patch makes sure DTR is dropped also on hangup and that DTR is only dropped for initialised ports (where is could have been raised in the first place).

The fourth and final patch, make sure no tty callbacks are made from tty_port_close_start when the port has not been initialised (successfully opened). This was previously only done for wait_until_sent but there's no reason to call flush_buffer or to honour port drain delay either. The latter could cause a failed open to stall for up to two seconds.

As a side-effect, this patches also fix an issue in USB-serial where we could get tty-port callbacks on an uninitialised port after having hung up and unregistered a device after disconnect.

Johan

Changes since RFC-series:
- fix up the two driver relying on tty_port_close_start directly but that did not manage DTR themselves

Johan Hovold (4):
TTY: clean up port shutdown
TTY: fix DTR not being dropped on hang up
TTY: clean up port drain-delay handling
TTY: fix close of uninitialised ports

 drivers/tty/mxser.c    |  4 +++
 drivers/tty/n_gsm.c    |  4 +++
 drivers/tty/tty_port.c | 71 ++++++++++++++++++++++++++++++--------------------
 3 files changed, 51 insertions(+), 28 deletions(-)
Signature · 6 lines
1.8.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html