Skip to content

RFC THP support for PPC64

Aneesh Kumar K.V linux-mm linuxppc-dev 1 version In review

Get series with b4
b4 am 1361465248-10867-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com

Versions newest first

  1. v1 RFC Latest21 patches 16 repliesIn review

Changes from RFC V1 from the cover letter

* HugeTLB fs now works
* Compile issues fixed
* rebased to v3.8
* Patch series reorded so that ppc64 cleanups and MM THP changes are moved early in the series. This should help in picking those patches early.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21powerpc: Use signed formatting when printing errorarch/powerpc/platforms/pseries/lpar.c+1 -11 reply
2/21powerpc: Save DAR and DSISR in pt_regs on MCEarch/powerpc/kernel/exceptions-64s.S arch/powerpc/xmon/xmon.c+10 -11 reply
3/21powerpc: Don't hard code the size of pte pagearch/powerpc/include/asm/pgtable.h arch/powerpc/mm/hash_low_64.S+8 -22 replies
4/21powerpc: Reduce the PTE_INDEX_SIZEarch/powerpc/include/asm/pgtable-ppc64-64k.h+2 -21 reply
5/21powerpc: Reduce PTE table memory wastagearch/powerpc/include/asm/mmu-book3e.h arch/powerpc/include/asm/mmu-hash64.h arch/powerpc/include/asm/page.h +6 more+392 -745 replies
6/21powerpc: Add size argument to pgtable_cache_addarch/powerpc/include/asm/pgtable-ppc64.h arch/powerpc/mm/init_64.c+14 -91 reply
7/21powerpc: Use encode avpn where we need only avpn valuesarch/powerpc/mm/hash_native_64.c arch/powerpc/platforms/cell/beat_htab.c arch/powerpc/platforms/ps3/htab.c+10 -101 reply
8/21powerpc: Decode the pte-lp-encoding bits correctly.arch/powerpc/include/asm/machdep.h arch/powerpc/include/asm/mmu-hash64.h arch/powerpc/kvm/book3s_hv.c +7 more+174 -1043 replies
9/21powerpc: Update tlbie/tlbiel as per ISA docarch/powerpc/mm/hash_native_64.c+40 -120 replies
10/21powerpc: print both base and actual page size on hash failurearch/powerpc/include/asm/mmu-hash64.h arch/powerpc/mm/hash_utils_64.c arch/powerpc/mm/hugetlbpage-hash64.c+10 -70 replies
11/21powerpc: Print page size info during bootarch/powerpc/mm/hash_utils_64.c+5 -50 replies
12/21powerpc: Fix hpte_decode to use the correct decoding for page sizesarch/powerpc/mm/hash_native_64.c+17 -100 replies
13/21mm/THP: HPAGE_SHIFT is not a #define on some archinclude/linux/huge_mm.h mm/huge_memory.c+6 -60 replies
14/21mm/THP: Add pmd args to pgtable deposit and withdraw APIsarch/s390/include/asm/pgtable.h arch/s390/mm/pgtable.c arch/sparc/include/asm/pgtable_64.h +4 more+27 -210 replies
15/21mm/THP: support for zerout withdraw.arch/s390/include/asm/pgtable.h arch/sparc/include/asm/pgtable_64.h include/asm-generic/pgtable.h +1 more+27 -10 replies
16/21powerpc/THP: Implement transparent huge pages for ppc64arch/powerpc/include/asm/page.h arch/powerpc/include/asm/pgtable-ppc64-64k.h arch/powerpc/include/asm/pgtable-ppc64.h +5 more+612 -30 replies
17/21powerpc/THP: Differentiate THP PMD entries from HUGETLB PMD entriesarch/powerpc/include/asm/pgtable.h arch/powerpc/mm/pgtable.c arch/powerpc/mm/pgtable_64.c+17 -50 replies
18/21powerpc/THP: Add code to handle HPTE faults for large pagesarch/powerpc/include/asm/mmu-hash64.h arch/powerpc/include/asm/pgtable-ppc64.h arch/powerpc/kernel/io-workarounds.c +10 more+257 -420 replies
19/21powerpc/THP: hypervisor require few WIMG bit setarch/powerpc/mm/largepage-hash64.c+2 -00 replies
20/21powerpc/THP: get_user_pages_fast changesarch/powerpc/mm/gup.c+82 -20 replies
21/21powerpc/THP: Enable THP on PPC64arch/powerpc/include/asm/pgtable.h+31 -20 replies

Reviews trailers per patch

3 of 21 patches have a Reviewed-by or Acked-by.

PatchPaul Mackerras
1/21A-b
2/21A-b
3/21
4/21A-b
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH -V2 00/21] THP support for PPC64

Hi,

This patchset adds transparent huge page support for PPC64.

I am marking the series to linux-mm because the PPC64 implementation required few interface changes to core THP code. I still have considerable number of FIXME!! in the patchset mostly related to PPC64 mm susbsytem. Those would require closer review and once we are clear on those changes, I will drop those FIXME!! with necessary comments.

Some numbers:

The latency measurements code from Anton found at
http://ozlabs.org/~anton/junkcode/latency2001.c

THP disabled 64K page size
------------------------
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 731.73 cycles 205.77 ns
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 743.39 cycles 209.05 ns
[root@llmp24l02 ~]#

THP disabled large page via hugetlbfs
-------------------------------------
[root@llmp24l02 ~]# ./latency2001 -l 8G
8589934592 416.09 cycles 117.01 ns
[root@llmp24l02 ~]# ./latency2001 -l 8G
8589934592 415.74 cycles 116.91 ns

THP enabled 64K page size.
----------------
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 405.07 cycles 113.91 ns
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 411.82 cycles 115.81 ns
[root@llmp24l02 ~]#

We are close to hugetlbfs in latency and we can achieve this with zero config/page reservation. Most of the allocations above are fault allocated. I haven't really measured the collapse alloc impact.

Another test that does 50000000 random access over 1GB area goes from 2.65 seconds to 1.07 seconds with this patchset.

Changes from RFC V1:
* HugeTLB fs now works
* Compile issues fixed
* rebased to v3.8
* Patch series reorded so that ppc64 cleanups and MM THP changes are moved early in the series. This should help in picking those patches early.

Thanks,
-aneesh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>