Skip to content

Xen: extend kexec hypercall for use with pv-ops kernels

David Vrabel kexec xen-devel 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest posting 2/29 patches 60 repliesIn review
  2. v10 posting 1/20 of 9 patches 0 repliesSuperseded
  3. v99 patches 39 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v89 patches14 repliesSuperseded
v7 posting 2/29 patches14 repliesSuperseded
v7 posting 1/20 of 9 patches0 repliesSuperseded
v610 patches27 repliesSuperseded
v4 posting 2/28 patches22 repliesSuperseded
v4 posting 1/20 of 8 patches0 repliesSuperseded
v38 patches25 repliesSuperseded
v18 patches84 repliesSuperseded

Changes in v10 from the cover letter

- Document host state on exec.
- Fix kimage_alloc() error path (double free, crash on zero kimage->head).
- Check for segment before expanding it in load_v1.
- Move kexec_lock define into kexec_swap_images().

Patches in v10 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86: give FIX_EFI_MPF its own fixmap entryxen/arch/x86/mpparse.c xen/include/asm-x86/fixmap.h+1 -20 replies
1/9x86: give FIX_EFI_MPF its own fixmap entryxen/arch/x86/mpparse.c xen/include/asm-x86/fixmap.h+1 -22 replies
2/9kexec: add public interface for improved load/unload sub-opsxen/common/kexec.c xen/include/public/kexec.h xen/include/public/xen-compat.h+95 -110 replies
2/9kexec: add public interface for improved load/unload sub-opsxen/common/kexec.c xen/include/public/kexec.h xen/include/public/xen-compat.h+95 -112 replies
3/9kexec: add infrastructure for handling kexec imagesxen/common/Makefile xen/common/kimage.c xen/include/xen/kimage.h+884 -00 replies
3/9kexec: add infrastructure for handling kexec imagesxen/common/Makefile xen/common/kimage.c xen/include/xen/kimage.h+884 -021 replies
4/9kexec: extend hypercall with improved load/unload opsxen/arch/x86/machine_kexec.c xen/arch/x86/x86_64/Makefile xen/arch/x86/x86_64/compat_kexec.S +7 more+804 -3361 reply
5/9xen: kexec crash image when dom0 crashesxen/common/kexec.c xen/common/shutdown.c+5 -00 replies
5/9xen: kexec crash image when dom0 crashesxen/common/kexec.c xen/common/shutdown.c+5 -02 replies
6/9libxc: add hypercall buffer arraystools/libxc/xc_hcall_buf.c tools/libxc/xenctrl.h+100 -00 replies
6/9libxc: add hypercall buffer arraystools/libxc/xc_hcall_buf.c tools/libxc/xenctrl.h+100 -02 replies
7/9libxc: add API for kexec hypercalltools/libxc/Makefile tools/libxc/xc_kexec.c tools/libxc/xenctrl.h+196 -00 replies
7/9libxc: add API for kexec hypercalltools/libxc/Makefile tools/libxc/xc_kexec.c tools/libxc/xenctrl.h+196 -02 replies
8/9x86: check kexec relocation code fits in a pagexen/arch/x86/xen.lds.S+2 -00 replies
8/9x86: check kexec relocation code fits in a pagexen/arch/x86/xen.lds.S+2 -02 replies
9/9MAINTAINERS: Add KEXEC maintainerMAINTAINERS+8 -00 replies
9/9MAINTAINERS: Add KEXEC maintainerMAINTAINERS+8 -02 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel KiperAndrew CooperIan CampbellDon SlutzKeir Fraser
SeriesR-b T-b R-b T-b T-b T-b A-b A-b
1/9R-b T-b R-b T-b R-b R-b R-b R-b
1/9R-b T-b R-b T-b R-b R-b R-b R-b
2/9R-b R-b R-b R-b
2/9R-b R-b R-b R-b
3/9R-b R-b R-b R-b R-b R-b T-b
3/9R-b R-b R-b R-b R-b R-b T-b
4/9R-b R-b
5/9R-b T-b R-b T-b R-b R-b R-b R-b
5/9R-b T-b R-b T-b R-b R-b R-b R-b
6/9R-b T-b R-b T-b R-b R-b A-b A-b R-b R-b
6/9R-b T-b R-b T-b R-b R-b A-b A-b R-b R-b
7/9R-b T-b R-b T-b R-b R-b A-b A-b R-b R-b
7/9R-b T-b R-b T-b R-b R-b A-b A-b R-b R-b
8/9R-b R-b R-b R-b
8/9R-b R-b R-b R-b
9/9R-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v10 thread

Cover letter [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

The series (for Xen 4.4) improves the kexec hypercall by making Xen responsible for loading and relocating the image. This allows kexec to be usable by pv-ops kernels and should allow kexec to be usable from a HVM or PVH privileged domain.

I have now tested this with a Linux kernel image using the VGA console which was what was causing problems in v9 (this turned out to be a kexec-tools bug).

The required patch series for kexec-tools will be posted shortly and are available from the xen-v7 branch of:

http://xenbits.xen.org/gitweb/?p=people/dvrabel/kexec-tools.git;a=summary

Changes in v10:

- Document host state on exec.
- Fix kimage_alloc() error path (double free, crash on zero kimage->head).
- Check for segment before expanding it in load_v1.
- Move kexec_lock define into kexec_swap_images().

Changes in v9:

- Update comments to correctly say 4.4.
- Minor updates the kexec_reloc assembly to improve maintainability a bit.

Changes in v8:

- Use #defines for compat ABI structures.
- Tweak link time check for kexec_reloc.

Changes in v7:

- No longer use GUEST_HANDLE_64(), get a uniform ABI by using unions and explicit padding.
- Only map the segments and not all of RAM.
- Add a mechanism to create mappings for use by the exec'd image (a segment with a NULL buf handle).
- Fix a bug where a crash image's code page would by placed at machine address 0 (instead of inside the crash region).

Changes in v6:

- Fix double free in KEXEC_load_v1 failure path.
- Only copy the relocation code and not the whole page.
- Add myself as the kexec maintainer.

Changes in v5 (not posted to the list):

- _rsvd -> _pad in one of the public ABI structures.
- Fix bug where trailing pages were not zeroed. This fixes loading a 64-bit Linux kernel using a more recent version of kexec-tools.
- Check the relocation code fits into a page at link time.

Changes in v4:

- Use paddr_t and page_to_maddr() etc. for portability.
- Add explicit padding to hypercall structures where required.
- Minor cleanup of the kexec_reloc assembly.
- Print a message before exec'ing a crash image.
- Style fixes (tabs, trailing whitespace) and typos.
- Fix a bug where using the V1 interface and unloading a image may crash.

Changes in v3:

- Provide old struct xen_kexec_load if __XEN_INTERFACE_VERSION__ < 4.3
- Adjust new struct xen_kexec_load to avoid unnecessary padding.
- Use domheap pages for the image and control pages.
- Remove the DBG() macros from the reloc code.

David

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec