Skip to content

Remove ARM local timer API

Stephen Boyd linux-arm-kernel linux-arm-msm lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 14 repliesIn review
  2. v611 patches 12 repliesSuperseded
  3. v511 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v411 patches4 repliesSuperseded
v310 patches20 repliesSuperseded
v210 patches20 repliesSuperseded
v18 patches10 repliesSuperseded

Changes in v7 from the cover letter

* Picked up acks and resent

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11clockevents: Prefer CPU local devices over global deviceskernel/time/tick-common.c+3 -213 replies
2/11clocksource: add generic dummy timer driverdrivers/clocksource/Makefile drivers/clocksource/dummy_timer.c+70 -01 reply
3/11ARM: smp: Remove duplicate dummy timer implementationarch/arm/kernel/smp.c+2 -200 replies
4/11ARM: smp_twd: Divorce smp_twd from local timer APIarch/arm/Kconfig arch/arm/kernel/smp_twd.c arch/arm/mach-highbank/Kconfig +8 more+56 -340 replies
5/11ARM: OMAP2+: Divorce from local timer APIarch/arm/mach-omap2/Kconfig arch/arm/mach-omap2/timer.c+0 -80 replies
6/11ARM: EXYNOS4: Divorce mct from local timer APIdrivers/clocksource/exynos_mct.c+43 -170 replies
7/11ARM: PRIMA2: Divorce timer-marco from local timer APIdrivers/clocksource/timer-marco.c+54 -460 replies
8/11ARM: msm: Divorce msm_timer from local timer APIarch/arm/mach-msm/timer.c+70 -560 replies
9/11clocksource: time-armada-370-xp: Fix sparse warningdrivers/clocksource/time-armada-370-xp.c include/linux/time-armada-370-xp.h+3 -40 replies
10/11clocksource: time-armada-370-xp: Divorce from local timer APIdrivers/clocksource/time-armada-370-xp.c+41 -480 replies
11/11ARM: smp: Remove local timer APIarch/arm/Kconfig arch/arm/include/asm/localtimer.h arch/arm/kernel/smp.c+0 -1130 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMark RutlandSören BrinkmannMarc ZyngierSantosh ShilimkarTony LindgrenKukjin KimDavid BrownGregory CLEMENTDaniel Lezcano
1/11T-b T-b T-b T-b A-b
2/11A-b A-b
3/11A-b
4/11T-b A-b
5/11A-b A-b A-b
6/11A-b A-b
7/11A-b
8/11A-b A-b
9/11A-b A-b
10/11A-b A-b T-b
11/11A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v7 thread

Cover letter [PATCHv7 00/11] Remove ARM local timer API

In light of Mark Rutland's recent work on divorcing the ARM architected timers from the ARM local timer API and introducing a generic arch hook for broadcast it seems that we should remove the local timer API entirely. Doing so will reduce the architecture dependencies of our timer drivers, reduce code in ARM core, and simplify timer drivers because they no longer go through an architecture layer that is essentially a hotplug notifier.

Previous attempts have been made[1] unsuccessfully. I'm hoping this can be accepted now so that we can clean up the timer drivers that are used in both UP and SMP situations. Right now these drivers have to ignore the timer setup callback on the boot CPU to avoid registering clockevents twice. This is not very symmetric and causes convuluted code that does the same thing in two places.

Patches based on v3.10-rc1

I'm still looking for Acks/Tested-by on PRIMA2.

[1] http://article.gmane.org/gmane.linux.ports.arm.kernel/145705

Note: A hotplug notifier is used by both x86 for the apb_timer (see apbt_cpuhp_notify) and by metag (see arch_timer_cpu_notify in metag_generic.c) so this is not new.

Changes since v6:
* Picked up acks and resent

Changes since v5:
* Rebased onto v3.10-rc1
* Rebase caused minor updates to mct patch

Changes since v4:
* Rebased onto next-20130418
* Rebase caused minor updates to mct patch and twd Kconfig

Changes since v3:
* New patch to fix SMP with dummy timers registered after a global timer
* Push this_cpu_ptr lower to avoid preemptible false positive warnings
* Collected acks/tested-bys

Changes since v2:
* Bug fixes in smp_twd from Tony Lindgren's testing
* Move smp_twd to use late_time_init hook
* Collected Acks

Changes since v1:
* Picked up Mark's generic dummy timer driver
* Split out omap changes into new patch

Mark Rutland (1):
clocksource: add generic dummy timer driver

Stephen Boyd (10):
clockevents: Prefer CPU local devices over global devices
ARM: smp: Remove duplicate dummy timer implementation
ARM: smp_twd: Divorce smp_twd from local timer API
ARM: OMAP2+: Divorce from local timer API
ARM: EXYNOS4: Divorce mct from local timer API
ARM: PRIMA2: Divorce timer-marco from local timer API
ARM: msm: Divorce msm_timer from local timer API
clocksource: time-armada-370-xp: Fix sparse warning
clocksource: time-armada-370-xp: Divorce from local timer API
ARM: smp: Remove local timer API

 arch/arm/Kconfig                         |  12 +--
 arch/arm/include/asm/localtimer.h        |  34 ---------
 arch/arm/kernel/smp.c                    |  87 ---------------------
 arch/arm/kernel/smp_twd.c                |  64 ++++++++++------
 arch/arm/mach-highbank/Kconfig           |   2 +-
 arch/arm/mach-imx/Kconfig                |   2 +-
 arch/arm/mach-msm/timer.c                | 126 +++++++++++++++++--------------
 arch/arm/mach-omap2/Kconfig              |   3 +-
 arch/arm/mach-omap2/timer.c              |   7 --
 arch/arm/mach-realview/Kconfig           |   8 +-
 arch/arm/mach-spear/Kconfig              |   2 +-
 arch/arm/mach-tegra/Kconfig              |   2 +-
 arch/arm/mach-ux500/Kconfig              |   2 +-
 arch/arm/mach-vexpress/Kconfig           |   2 +-
 arch/arm/mach-zynq/Kconfig               |   2 +-
 drivers/clocksource/Makefile             |   1 +
 drivers/clocksource/dummy_timer.c        |  69 +++++++++++++++++
 drivers/clocksource/exynos_mct.c         |  60 ++++++++++-----
 drivers/clocksource/time-armada-370-xp.c |  92 +++++++++++-----------
 drivers/clocksource/timer-marco.c        | 100 +++++++++++++-----------
 include/linux/time-armada-370-xp.h       |   4 +-
 kernel/time/tick-common.c                |   5 +-
 22 files changed, 340 insertions(+), 346 deletions(-)
 delete mode 100644 arch/arm/include/asm/localtimer.h
 create mode 100644 drivers/clocksource/dummy_timer.c
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation