Skip to content

Bluetooth: Add HCI transaction framework

Johan Hedberg linux-bluetooth 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 16 repliesIn review
  2. v2 posting 2/215 patches 0 repliesSuperseded
  3. v2 posting 1/21 of 14 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v114 patches2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16Bluetooth: Fix __hci_request() handling of empty requestsnet/bluetooth/hci_core.c+8 -00 replies
2/16Bluetooth: Split HCI init sequence into three stagesnet/bluetooth/hci_core.c net/bluetooth/hci_event.c+271 -2552 replies
3/16Bluetooth: Add initial skeleton for HCI transaction frameworkinclude/net/bluetooth/bluetooth.h include/net/bluetooth/hci_core.h net/bluetooth/hci_core.c+58 -07 replies
4/16Bluetooth: Refactor HCI command skb creationnet/bluetooth/hci_core.c+20 -80 replies
5/16Bluetooth: Introduce new hci_transaction_cmd functioninclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c+35 -00 replies
6/16Bluetooth: Introduce a hci_transaction_from_skb functioninclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/hci_sock.c+11 -40 replies
7/16Bluetooth: Add transaction cmd_complete and cmd_status functionsinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/hci_event.c+77 -00 replies
8/16Bluetooth: Convert hci_request to use HCI transaction frameworkinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/hci_event.c+181 -1950 replies
9/16Bluetooth: Remove unused hdev->init_last_cmdinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c+0 -80 replies
10/16Bluetooth: Move power on HCI command updates to their own functionnet/bluetooth/mgmt.c+40 -360 replies
11/16Bluetooth: Update mgmt powered HCI commands to use transactionsnet/bluetooth/mgmt.c+99 -480 replies
12/16Bluetooth: Wait for HCI command completion with mgmt_set_powerednet/bluetooth/mgmt.c+30 -120 replies
13/16Bluetooth: Fix busy condition testing for EIR and class updatesnet/bluetooth/mgmt.c+30 -95 replies
14/16Bluetooth: Fix UUID/class mgmt command response synchronizationnet/bluetooth/mgmt.c+46 -230 replies
15/16Bluetooth: Remove useless HCI_PENDING_CLASS flaginclude/net/bluetooth/hci.h net/bluetooth/hci_event.c net/bluetooth/mgmt.c+3 -120 replies
16/16Bluetooth: Remove empty HCI event handlersnet/bluetooth/hci_event.c+0 -1640 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/16] Bluetooth: Add HCI transaction framework

Hi,

Here's a revised set with the left-over init_last_cmd patch inserted where it belongs in the set.

The other changes are based on an (off-list) review from Gustavo Padovan, resulting in removing unnecessary _irqsave versions of spinlock functions (for the skb queue), adding a hci_ prefix to some static hci_core.c functions as well as really removing the HCI_PENDING_CLASS flag (and not just its users).

Johan

----------------------------------------------------------------
Johan Hedberg (16):
Bluetooth: Fix __hci_request() handling of empty requests
Bluetooth: Split HCI init sequence into three stages
Bluetooth: Add initial skeleton for HCI transaction framework
Bluetooth: Refactor HCI command skb creation
Bluetooth: Introduce new hci_transaction_cmd function
Bluetooth: Introduce a hci_transaction_from_skb function
Bluetooth: Add transaction cmd_complete and cmd_status functions
Bluetooth: Convert hci_request to use HCI transaction framework
Bluetooth: Remove unused hdev->init_last_cmd
Bluetooth: Move power on HCI command updates to their own function
Bluetooth: Update mgmt powered HCI commands to use transactions
Bluetooth: Wait for HCI command completion with mgmt_set_powered
Bluetooth: Fix busy condition testing for EIR and class updates
Bluetooth: Fix UUID/class mgmt command response synchronization
Bluetooth: Remove useless HCI_PENDING_CLASS flag
Bluetooth: Remove empty HCI event handlers

 include/net/bluetooth/bluetooth.h |   11 +
 include/net/bluetooth/hci.h       |    1 -
 include/net/bluetooth/hci_core.h  |   20 +-
 net/bluetooth/hci_core.c          |  649 ++++++++++++++++++++++++++++++++-----
 net/bluetooth/hci_event.c         |  507 +----------------------------
 net/bluetooth/hci_sock.c          |    3 +-
 net/bluetooth/mgmt.c              |  326 +++++++++++++------
 7 files changed, 826 insertions(+), 691 deletions(-)