Skip to content

FIFO underrun reporting v2

Paulo Zanoni intel-gfx 1 version Applied

Status from this message: Queued for -next, thanks for the patch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4drm/i915: also disable south interrupts when handling themdrivers/gpu/drm/i915/i915_irq.c+24 -24 replies
2/4drm/i915: report Gen5+ CPU and PCH FIFO underrunsdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c +1 more+334 -133 replies
3/4drm/i915: print Gen5+ CPU/PCH poison interruptsdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+14 -21 reply
4/4drm/i915: remove "inline" keyword from ironlake_disable_display_irqdrivers/gpu/drm/i915/i915_irq.c+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] FIFO underrun reporting v2

From: Paulo Zanoni <[email protected]>

Hi

Here's a new series that tries to report FIFO underruns. The new implementation is completely different from the old one, due to the reviews I received. Now we don't just "ignore" the FIFO underrun interrupts when we receive them, we effectively disable the interrupts (the downsides of this approach are documented in the commit message of patch 2).

We will still see at most one of each error FIFO underrun message per mode set, so this is not really going to flood dmesg. I tested this series on ILK, SNB and HSW, and I am only seeing FIFO underruns on ILK when using 2 monitors (LVDS+HDMI). I'll work on a patch to fix this message later (at least now we know we have problems!).

It seems not everybody is in favor of adding the "poison" error message, so the "print poison interrupts" patch comes _after_ the "print FIFO underruns". We can discard the patch if we conclude we don't want it. I haven't seen the poison message on any of my tests.

Thanks,
Paulo

Paulo Zanoni (4):
drm/i915: also disable south interrupts when handling them drm/i915: report Gen5+ CPU and PCH FIFO underruns drm/i915: print Gen5+ CPU/PCH poison interrupts drm/i915: remove "inline" keyword from ironlake_disable_display_irq

 drivers/gpu/drm/i915/i915_irq.c      |  345 ++++++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/i915_reg.h      |   15 +-
 drivers/gpu/drm/i915/intel_display.c |   17 +-
 drivers/gpu/drm/i915/intel_drv.h     |   10 +
 4 files changed, 371 insertions(+), 16 deletions(-)
Signature · 1 line
1.7.10.4