Skip to content

Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

Egbert Eich intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12DRM/i915: Remove valleyview_hpd_irq_setup.drivers/gpu/drm/i915/i915_irq.c+1 -251 reply
2/12DRM/I915: Add enum hpd_pin to intel_encoder.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_dp.c +3 more+27 -01 reply
3/12DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in encoders.drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+132 -602 replies
3/12DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in encoders (v2)drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+123 -600 replies
4/12DRM/i915: Remove i965_hpd_irq_setup.drivers/gpu/drm/i915/i915_irq.c+18 -350 replies
5/12DRM/i915: Get rid if the 'hotplug_supported_mask' in struct drm_i915_private.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_dp.c +2 more+3 -152 replies
6/12DRM/i915: Add HPD IRQ storm detection.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+60 -121 reply
6/12DRM/i915: Add HPD IRQ storm detection (v2)drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+60 -121 reply
6/12DRM/i915: Add HPD IRQ storm detection (v3)drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+60 -120 replies
7/12DRM/i915: (re)init HPD interrupt storm statistics.drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_dp.c +4 more+22 -100 replies
8/12DRM/i915: Treat hpd_irq_setup() for ironake and older generations the same way.drivers/gpu/drm/i915/i915_irq.c+5 -50 replies
9/12DRM/i915: Disable HPD interrupt on pin when irq storm is detected.drivers/gpu/drm/i915/i915_irq.c+53 -160 replies
9/12DRM/i915: Disable HPD interrupt on pin when irq storm is detected (v2)drivers/gpu/drm/i915/i915_irq.c+53 -160 replies
10/12DRM/i915: Add Reenable Timer to turn Hotplug Detection back on.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+54 -11 reply
10/12DRM/i915: Add Reenable Timer to turn Hotplug Detection back on (v2).drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+54 -11 reply
10/12DRM/i915: Add Reenable Timer to turn Hotplug Detection back on (v3).drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+54 -10 replies
11/12DRM/i915: Add bit field to record which pins have received HPD events.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+11 -00 replies
11/12DRM/i915: Add bit field to record which pins have received HPD events (v2)drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+11 -00 replies
11/12DRM/i915: Add bit field to record which pins have received HPD events (v3)drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+42 -61 reply
12/12DRM/i915: Only reprobe display on encoder which has received an HPD event.drivers/gpu/drm/i915/i915_irq.c+31 -60 replies
12/12DRM/i915: Only reprobe display on encoder which has received an HPD event.drivers/gpu/drm/i915/i915_irq.c+31 -60 replies

Reviews trailers per patch

7 of 21 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChris WilsonJesse Barnes
SeriesA-b
1/12R-b
2/12R-b
3/12A-b R-b
3/12A-b R-b
4/12
5/12
6/12A-b A-b
6/12A-b A-b
6/12A-b A-b
7/12
8/12
9/12
9/12
10/12
10/12
10/12
11/12
11/12
11/12
12/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v.2 00/12] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

I've reworked my 'hotplug interrupt storm detection'-patches and included most of Daniel's suggestions.
I've looked into adding EDID caching but since this requires some larger scale changes and some changes outside of the Intel driver it seemed to be a good idea to propose those changes at a later time.

Egbert Eich (12):
DRM/i915: Remove valleyview_hpd_irq_setup.
DRM/I915: Add enum hpd_pin to intel_encoder.
DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in
encoders.
DRM/i915: Remove i965_hpd_irq_setup.
DRM/i915: Get rid if the 'hotplug_supported_mask' in struct

    drm_i915_private.

DRM/i915: Add HPD IRQ storm detection.
DRM/i915: (re)init HPD interrupt storm statistics. DRM/i915: Treat hpd_irq_setup() for ironake and older generations the
same way.
DRM/i915: Disable HPD interrupt on pin when irq storm is detected. DRM/i915: Add Reenable Timer to turn Hotplug Detection back on. DRM/i915: Add bit field to record which pins have received HPD
events.
DRM/i915: Only reprobe display on encoder which has received an HPD
event.

 drivers/gpu/drm/i915/i915_drv.h   |   26 +++-
 drivers/gpu/drm/i915/i915_irq.c   |  404 ++++++++++++++++++++++++++-----------
 drivers/gpu/drm/i915/i915_reg.h   |   32 +++-
 drivers/gpu/drm/i915/intel_crt.c  |   10 +-
 drivers/gpu/drm/i915/intel_dp.c   |    8 +-
 drivers/gpu/drm/i915/intel_drv.h  |    5 +
 drivers/gpu/drm/i915/intel_hdmi.c |    8 +-
 drivers/gpu/drm/i915/intel_sdvo.c |   17 +-
 drivers/gpu/drm/i915/intel_tv.c   |    2 +-
 9 files changed, 372 insertions(+), 140 deletions(-)
Signature · 1 line
1.7.7