Skip to content

btrfs-progs: More misc fixes & cleanups

Eric Sandeen linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17btrfs-progs: Unify size-parsingcmds-qgroup.c utils.c utils.h+14 -406 replies
2/17btrfs-progs: fix btrfs_get_subvol cut/paste errorbtrfs-list.c+10 -120 replies
3/17btrfs-progs: Remove write-only var fdres in cmd_dev_stats()cmds-device.c+0 -30 replies
4/17btrfs-progs: btrfs_list_get_path_rootid error handlingbtrfs-list.c btrfs-list.h cmds-subvolume.c+33 -140 replies
5/17btrfs-progs: avoid double-free in __btrfs_map_blockvolumes.c+1 -00 replies
6/17btrfs-progs: fix open error test in cmd_start_replacecmds-replace.c+1 -10 replies
7/17btrfs-progs: fix close of error fd in scrub cancelcmds-scrub.c+5 -80 replies
8/17btrfs-progs: more scrub cancel error handlingcmds-scrub.c+11 -40 replies
9/17btrfs-progs: free memory before error exit in read_whole_ebdisk-io.c+5 -10 replies
10/17btrfs-progs: don't call close on error fdbtrfs-show-super.c+0 -10 replies
11/17btrfs-progs: provide positive errno to strerror in cmd_restorecmds-restore.c+1 -10 replies
12/17btrfs-progs: free allocated di_args in cmd_start_replacecmds-replace.c+1 -00 replies
13/17btrfs-progs: close fd on cmd_subvol_get_default returncmds-subvolume.c+12 -80 replies
14/17btrfs-progs: fix mem leak in resolve_rootbtrfs-list.c+6 -24 replies
15/17btrfs-progs: Tidy up resolve_rootbtrfs-list.c+8 -50 replies
16/17btrfs-progs: fix fd leak in cmd_subvol_set_defaultcmds-subvolume.c+9 -84 replies
17/17btrfs-progs: replace strtok_r with strsepcmds-balance.c+4 -87 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] btrfs-progs: More misc fixes & cleanups

A bunch of Coverity static analysis checker fixes, including a couple actual bugfixes.

This gets it down from around 80 defects to about 50; I have a couple other patches I need to clean up which quiets it even more.

By getting it to a tolerable level, subsequent runs to check for regressions & new problems should be more manageable...

thanks,
-Eric

[PATCH 01/17] btrfs-progs: Unify size-parsing
[PATCH 02/17] btrfs-progs: fix btrfs_get_subvol cut/paste error [PATCH 03/17] btrfs-progs: Remove write-only var fdres in cmd_dev_stats() [PATCH 04/17] btrfs-progs: btrfs_list_get_path_rootid error handling [PATCH 05/17] btrfs-progs: avoid double-free in __btrfs_map_block [PATCH 06/17] btrfs-progs: fix open error test in cmd_start_replace [PATCH 07/17] btrfs-progs: fix close of error fd in scrub cancel [PATCH 08/17] btrfs-progs: more scrub cancel error handling [PATCH 09/17] btrfs-progs: free memory before error exit in read_whole_eb [PATCH 10/17] btrfs-progs: don't call close on error fd
[PATCH 11/17] btrfs-progs: provide positive errno to strerror in cmd_restore [PATCH 12/17] btrfs-progs: free allocated di_args in cmd_start_replace [PATCH 13/17] btrfs-progs: close fd on cmd_subvol_get_default return [PATCH 14/17] btrfs-progs: fix mem leak in resolve_root
[PATCH 15/17] btrfs-progs: Tidy up resolve_root
[PATCH 16/17] btrfs-progs: fix fd leak in cmd_subvol_set_default [PATCH 17/17] btrfs-progs: replace strtok_r with strsep