Skip to content

sctp: fix association hangs due to reassembly/ordering logic

Lee A. Roberts linux-sctp netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 10 repliesSuperseded
  3. v14 patches 14 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow()net/sctp/tsnmap.c+7 -60 replies
2/4sctp: fix association hangs due to reneging packets below the cumulative TSN ACK pointnet/sctp/ulpqueue.c+7 -20 replies
3/4sctp: fix association hangs due to errors when reneging events from the ordering queuenet/sctp/ulpqueue.c+22 -40 replies
4/4sctp: fix association hangs due to partial delivery errorsnet/sctp/ulpqueue.c+43 -110 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVlad Yasevich
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] sctp: fix association hangs due to reassembly/ordering logic

From: "Lee A. Roberts" <[email protected]>

This series of patches resolves several SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association reassembly and/or lobby (ordering) queues. Close examination of reassembly/ordering queues may show either duplicated or missing packets.

In version #2, corrected build failure in initial version of patch series due to wrong calling sequence for sctp_ulpq_partial_delivery() being inserted in sctp_ulpq_renege().

In version #3, adjusted patch documentation to be less repetitive.

Lee A. Roberts (4):
sctp: fix association hangs due to off-by-one errors in
sctp_tsnmap_grow()
sctp: fix association hangs due to reneging packets below the
cumulative TSN ACK point
sctp: fix association hangs due to errors when reneging events from
the ordering queue
sctp: fix association hangs due to partial delivery errors

 net/sctp/tsnmap.c   |   13 ++++----
 net/sctp/ulpqueue.c |   87 +++++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 78 insertions(+), 22 deletions(-)
Signature · 1 line
1.7.9.5