Skip to content

timer_list: Fix /proc/timer_list failure on 4096 cpus

Nathan Zimmer lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 2 repliesIn review
  2. v32 patches 3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2timer_list: split timer_list_show_tickdeviceskernel/time/timer_list.c+9 -120 replies
2/2timer_list: convert timer list to be a proper seq_filekernel/time/timer_list.c+77 -122 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/2] timer_list: Fix /proc/timer_list failure on 4096 cpus

On systems with 4096 cores attemping to read /proc/timer_list fails because we are trying to push all the data into a single kmalloc buffer.

A better solution is to not us the single_open mechanism but to provide our own seq_operations and treat each cpu as an individual record.

The output should be identical to the previous version.

v2: Added comments on the iteration and other fixups pointed to by Andrew.
v3: Corrected the case where max_cpus != nr_cpu_ids by exiting early.
v5: Use seq_open_private and supply a proper iterator rather then a big mess.

Nathan Zimmer (2):
timer_list: split timer_list_show_tickdevices
timer_list: convert timer list to be a proper seq_file

 kernel/time/timer_list.c | 104 +++++++++++++++++++++++++++++++++++++----------
 1 file changed, 83 insertions(+), 21 deletions(-)
Signature · 1 line
1.8.1.2