Skip to content

RFC HID: Introduce .idle() to remove last usb dependence from hid-multitouch

Benjamin Tissoires linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2HID: Extend the interface with idle requestsdrivers/hid/usbhid/hid-core.c include/linux/hid.h+34 -03 replies
2/2HID: multitouch: remove last usb dependencydrivers/hid/hid-multitouch.c+1 -160 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Herrmann
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/2] HID: Introduce .idle() to remove last usb dependence from hid-multitouch

Hi guys,

Well, this series of two patches aims at removing the dependence between usb and hid-multitouch.
I put a RFC and not a patch as I'm not satisfied with the result:
- adding this callback for one use may not be accurate
- the parameters may not be good either (HID_REQ_SET_IDLE is the only valid value for now as noone seems to be using HID_REQ_GET_IDLE)
- the return value is clearly not very interesting.
- maybe we should just add HID_REQ_SET_IDLE to .request, but this will require a few changes in the parameters.

The main purpose of this RFC was to share it with David this new ll callback, so that we can have a global view of what is needed.

Thanks for the inputs.

Cheers,
Benjamin

Benjamin Tissoires (2):
HID: Extend the interface with idle requests
HID: multitouch: remove last usb dependency

 drivers/hid/hid-multitouch.c  | 17 +----------------
 drivers/hid/usbhid/hid-core.c | 15 +++++++++++++++
 include/linux/hid.h           | 19 +++++++++++++++++++
 3 files changed, 35 insertions(+), 16 deletions(-)
Signature · 1 line
1.8.1.2