Skip to content

Provide default fdb operation to allow mac filter setting

Vlad Yasevich netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/24 patches 1 replyIn review
  2. v2 posting 1/24 patches 4 repliesSuperseded
  3. v14 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Restore ixgbe implementation of fdb_add since it needs to enforce the limit of addresses in SR-IOV case.

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: generic fdb support for drivers without ndo_fdb_<op>include/linux/rtnetlink.h net/core/rtnetlink.c+84 -60 replies
2/4ixgbe: Make use of the default fdb handlers.drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+1 -410 replies
3/4mlx4: Remove driver specific fdb handlers.drivers/net/ethernet/mellanox/mlx4/en_netdev.c+0 -760 replies
4/4qlcnic: Use generic fdb handler when driver options are not enabled.drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c+6 -150 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchJohn FastabendJitendra Kalsaria
1/4
2/4A-b
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 resent net-next 0/4] Provide default fdb operation to allow mac filter setting

This is a short series that now allows mac filter programming on any card that support IFF_UNICAST_FLT by using the existing FDB interface.

Some existing drivers that had FDB functionality usually supported it only in SR-IOV mode. Since that's not always enabled, and we want to take advantage of IFF_UNICAST_FLT support, these drivers have been converted to call the default handler when not in SRIOV mode.

Changes since v1:
- Restore ixgbe implementation of fdb_add since it needs to enforce the limit of addresses in SR-IOV case.

Changes since RFC:
- Removed ixgbe and mlx versions of fdb calls as recommened.
- Added qlogic patch to use default calls when module parameter is not turned on.

Vlad Yasevich (4):
net: generic fdb support for drivers without ndo_fdb_<op>
ixgbe: Make use of the default fdb handlers.
mlx4: Remove driver specific fdb handlers.
qlcnic: Use generic fdb handler when driver options are not enabled.

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |   42 +-----------
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c   |   76 --------------------
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |   21 ++----
 include/linux/rtnetlink.h                        |    9 +++
 net/core/rtnetlink.c                             |   81 ++++++++++++++++++++--
 5 files changed, 91 insertions(+), 138 deletions(-)
Signature · 1 line
1.7.7.6