Skip to content

block: Add driver specific options

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block: Add options QDict to .bdrv_open()block.c block/bochs.c block/cloop.c +11 more+17 -171 reply
2/7block: Add options QDict to bdrv_open() prototypeblock.c block/blkverify.c block/qcow2.c +9 more+54 -281 reply
3/7Add qdict_clone_shallow()include/qapi/qmp/qdict.h qobject/qdict.c+24 -01 reply
4/7block: Add options QDict to bdrv_open_common()block.c+26 -62 replies
5/7qemu-option: Add qemu_opts_absorb_qdict()include/qemu/option.h util/qemu-option.c+35 -01 reply
6/7block: Support driver specific options in drive_init()blockdev.c+40 -51 reply
7/7qcow2: Allow lazy refcounts to be enabled on the command lineblock/qcow2-cluster.c block/qcow2.c block/qcow2.h+39 -11 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakeStefan Hajnoczi
SeriesR-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] block: Add driver specific options

Instead of constantly keeping complaining that we need this big -blockdev things, let's start attacking individual parts of the project. Here is the first part, allowing block drivers to provide additional -drive options.

Any options that isn't processed by the block layer is passed to the driver which can use them. If it doesn't, you get an error message like today. At the end of this series you can specify:

-drive file=test.qcow2,lazy_refcounts=on

This doesn't include a way to specify options for backing files yet, but I don't think there's anything blocking such extensions on top.

Kevin Wolf (7):
block: Add options QDict to .bdrv_open()
block: Add options QDict to bdrv_open() prototype Add qdict_clone_shallow()
block: Add options QDict to bdrv_open_common()
qemu-option: Add qemu_opts_absorb_qdict()
block: Support driver specific options in drive_init()
qcow2: Allow lazy refcounts to be enabled on the command line

 block.c                   | 81 ++++++++++++++++++++++++++++++++++++-----------
 block/blkverify.c         |  2 +-
 block/bochs.c             |  2 +-
 block/cloop.c             |  2 +-
 block/cow.c               |  2 +-
 block/dmg.c               |  2 +-
 block/parallels.c         |  2 +-
 block/qcow.c              |  2 +-
 block/qcow2-cluster.c     |  2 +-
 block/qcow2.c             | 43 +++++++++++++++++++++++--
 block/qcow2.h             |  1 +
 block/qed.c               |  4 +--
 block/raw.c               |  2 +-
 block/vdi.c               |  2 +-
 block/vmdk.c              |  4 +--
 block/vpc.c               |  2 +-
 block/vvfat.c             |  2 +-
 blockdev.c                | 53 ++++++++++++++++++++++++++-----
 hw/xen_disk.c             |  2 +-
 include/block/block.h     |  4 +--
 include/block/block_int.h |  3 +-
 include/qapi/qmp/qdict.h  |  2 ++
 include/qemu/option.h     |  1 +
 qemu-img.c                |  6 ++--
 qemu-io.c                 |  2 +-
 qemu-nbd.c                |  2 +-
 qobject/qdict.c           | 22 +++++++++++++
 util/qemu-option.c        | 34 ++++++++++++++++++++
 28 files changed, 233 insertions(+), 55 deletions(-)
Signature · 1 line
1.8.1.2