Skip to content

em28xx: i2c debugging cleanups and support for newer eeproms

Frank Schäfer linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 6 repliesIn review
  2. v111 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- fixed the sanity check in patch 8
- fixed a minor output format issue in patch 10

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11em28xx-i2c: replace printk() with the corresponding em28xx macrosdrivers/media/usb/em28xx/em28xx-i2c.c+24 -313 replies
2/11em28xx-i2c: get rid of the dprintk2 macrodrivers/media/usb/em28xx/em28xx-i2c.c+6 -110 replies
3/11em28xx-i2c: also print debug messages at debug level 1drivers/media/usb/em28xx/em28xx-i2c.c+6 -60 replies
4/11em28xx: do not interpret eeprom content if eeprom key is invaliddrivers/media/usb/em28xx/em28xx-i2c.c+6 -20 replies
5/11em28xx: fix eeprom data endianessdrivers/media/usb/em28xx/em28xx-i2c.c drivers/media/usb/em28xx/em28xx.h+18 -160 replies
6/11em28xx: make sure we are at i2c bus A when calling em28xx_i2c_register()drivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-i2c.c+20 -183 replies
7/11em28xx: add basic support for eeproms with 16 bit address widthdrivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-i2c.c drivers/media/usb/em28xx/em28xx.h+49 -250 replies
8/11em28xx: add helper function for reading data blocks from i2c clientsdrivers/media/usb/em28xx/em28xx-i2c.c+46 -280 replies
9/11em28xx: do not store eeprom content permanentlydrivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-i2c.c drivers/media/usb/em28xx/em28xx.h+31 -150 replies
10/11em28xx: extract the device configuration dataset from eeproms with 16 bit address widthdrivers/media/usb/em28xx/em28xx-i2c.c drivers/media/usb/em28xx/em28xx.h+85 -360 replies
11/11em28xx: enable tveeprom for device Hauppauge HVR-930Cdrivers/media/usb/em28xx/em28xx-cards.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/11] em28xx: i2c debugging cleanups and support for newer eeproms

The first 3 patches clean up / simplify the debugging and info messages a bit.

Patches 4, 5 and 6 fix two bugs I've noticed while working on the eeprom stuff.

Patches 7-10 add support for the newer eeproms with 16 bit address width. This allows us to display the eeprom content, to calculate the eeprom hash for board hints for devices with generic USB IDs, to read the device configuration and to use tveeprom for Hauppauge devices just as with the old eeprom type.

The used eeprom type depends on the chip type/id (confirmed by the Empia datasheets). For unknown chips, the old 8 bit eeprom type is assumed, which makes sure that the eeprom content can't be damaged accidentally.
In video capturing/TV/DVB devices, the new eeprom still has the old eeprom content (device configuration + tveeprom structure for Hauppauge devices) embedded. Camera devices (em25xx, em276x+) however are using a different data structure, which isn't supported yet.

Patch 11 is a follow-up which enables tveeprom for the Hauppauge HVR-930C

All patches have been tested with the following devices:
- Hauppauge HVR-900 (normal 8 bit eeprom)
- Hauppauge HVR-930C (16 bit eeprom, tveeprom)
- SpeedLink VAD Laplace webcam (16 bit eeprom, no device config dataset)

I also checked the USB log of the MSI Digivox ATSC which confirms that non-Hauppauge devices are using the same eeprom format.

Changes since v1:
- fixed the sanity check in patch 8
- fixed a minor output format issue in patch 10

Frank Schäfer (11):
em28xx-i2c: replace printk() with the corresponding em28xx macros
em28xx-i2c: get rid of the dprintk2 macro
em28xx-i2c: also print debug messages at debug level 1
em28xx: do not interpret eeprom content if eeprom key is invalid
em28xx: fix eeprom data endianess
em28xx: make sure we are at i2c bus A when calling

    em28xx_i2c_register()

em28xx: add basic support for eeproms with 16 bit address width
em28xx: add helper function for reading data blocks from i2c clients
em28xx: do not store eeprom content permanently
em28xx: extract the device configuration dataset from eeproms with 16
bit address width
em28xx: enable tveeprom for device Hauppauge HVR-930C

 drivers/media/usb/em28xx/em28xx-cards.c |   45 +++--
 drivers/media/usb/em28xx/em28xx-i2c.c   |  284 ++++++++++++++++++++-----------
 drivers/media/usb/em28xx/em28xx.h       |   17 +-

3 Dateien geändert, 225 Zeilen hinzugefügt(+), 121 Zeilen entfernt(-)

Signature · 1 line
1.7.10.4