Skip to content

brcm80211: cleanup and rework changes

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13brcmsmac: radio on led supportdrivers/net/wireless/brcm80211/Kconfig drivers/net/wireless/brcm80211/brcmsmac/Makefile drivers/net/wireless/brcm80211/brcmsmac/led.c +3 more+178 -20 replies
2/13brcmfmac: introduce tracepoints for message loggingdrivers/net/wireless/brcm80211/brcmfmac/Makefile drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c +3 more+159 -70 replies
3/13brcmfmac: make debug module parameter more cleardrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+2 -10 replies
4/13brcmfmac: cleanup module information macrosdrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/usb.c+1 -60 replies
5/13brcmfmac: only do auth_type workaround when no WPA or RSN IE is provideddrivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+3 -14 replies
6/13brcmfmac: remove null-pointer check in .sched_scan_start() callbackdrivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+3 -30 replies
7/13brcmfmac: increase required skbuff headroom for firmware signallingdrivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c+15 -20 replies
8/13brcmutil: add macros for setting bitfields using mask/shift operationsdrivers/net/wireless/brcm80211/include/brcmu_utils.h+23 -00 replies
9/13brcmfmac: add support for TLV based firmware signallingdrivers/net/wireless/brcm80211/brcmfmac/Makefile drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c +6 more+501 -180 replies
10/13brcmfmac: release transmit packet in brcmf_txcomplete()drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c +1 more+8 -150 replies
11/13brcmfmac: assure brcmf_txcomplete() is called in failure pathsdrivers/net/wireless/brcm80211/brcmfmac/usb.c+17 -120 replies
12/13brcmutil: add dequeue function with filteringdrivers/net/wireless/brcm80211/brcmutil/utils.c drivers/net/wireless/brcm80211/include/brcmu_utils.h+29 -00 replies
13/13brcmfmac: add parameter to brcmf_proto_hdrpush() for data offsetdrivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/dhd_proto.h+4 -50 replies

Reviews trailers per patch

12 of 13 patches have a Reviewed-by or Acked-by.

PatchPieter-Paul GiesbertsHante MeulemanPiotr HaberArend van Spriel
1/13R-b R-b R-b
2/13R-b R-b R-b
3/13R-b R-b
4/13
5/13R-b
6/13R-b R-b
7/13R-b R-b
8/13R-b R-b
9/13R-b R-b
10/13R-b R-b R-b
11/13R-b R-b
12/13R-b R-b R-b
13/13R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/13] brcm80211: cleanup and rework changes

This series does contain one brcmsmac patch to provide WLAN led support. It is only compiled when BCMA_DRIVER_GPIO is set. The brcmfmac patches contain cleanup of the module related macros and patches that rework the driver for upcoming firmware feature support. In this series also adding support for tracepoints allowing tracing all driver debug messages.

This patch series is intended for v3.10 and applies to master branch in the wireless-next repository.

Arend van Spriel (12):
brcmfmac: introduce tracepoints for message logging
brcmfmac: make debug module parameter more clear
brcmfmac: cleanup module information macros
brcmfmac: only do auth_type workaround when no WPA or RSN IE is
provided
brcmfmac: remove null-pointer check in .sched_scan_start() callback
brcmfmac: increase required skbuff headroom for firmware signalling
brcmutil: add macros for setting bitfields using mask/shift
operations
brcmfmac: add support for TLV based firmware signalling
brcmfmac: release transmit packet in brcmf_txcomplete()
brcmfmac: assure brcmf_txcomplete() is called in failure paths
brcmutil: add dequeue function with filtering
brcmfmac: add parameter to brcmf_proto_hdrpush() for data offset

Piotr Haber (1):
brcmsmac: radio on led support

 drivers/net/wireless/brcm80211/Kconfig             |    5 +-
 drivers/net/wireless/brcm80211/brcmfmac/Makefile   |    3 +
 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |    7 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h  |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c  |   30 ++-
 .../net/wireless/brcm80211/brcmfmac/dhd_common.c   |   33 ++
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c  |   42 +++
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h  |   34 ++-
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |   39 ++-
 .../net/wireless/brcm80211/brcmfmac/dhd_proto.h    |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |   28 +-
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c |  382 ++++++++++++++++++++
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h |   25 ++
 .../net/wireless/brcm80211/brcmfmac/tracepoint.c   |   22 ++
 .../net/wireless/brcm80211/brcmfmac/tracepoint.h   |   87 +++++
 drivers/net/wireless/brcm80211/brcmfmac/usb.c      |   37 +-
 .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c  |   10 +-
 drivers/net/wireless/brcm80211/brcmsmac/Makefile   |    4 +
 drivers/net/wireless/brcm80211/brcmsmac/led.c      |  127 +++++++
 drivers/net/wireless/brcm80211/brcmsmac/led.h      |   36 ++
 .../net/wireless/brcm80211/brcmsmac/mac80211_if.c  |    4 +
 .../net/wireless/brcm80211/brcmsmac/mac80211_if.h  |    4 +
 drivers/net/wireless/brcm80211/brcmutil/utils.c    |   25 ++
 .../net/wireless/brcm80211/include/brcmu_utils.h   |   27 ++
 24 files changed, 943 insertions(+), 72 deletions(-)
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/tracepoint.c
 create mode 100644 drivers/net/wireless/brcm80211/brcmfmac/tracepoint.h
 create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/led.c
 create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/led.h
Signature · 1 line
1.7.6