Skip to content

make netlayer re-entrant

Liu Ping Fan qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 9 repliesIn review
  2. v13 patches 17 repliesSuperseded

Changes in v2 from the cover letter

Because the NetQueue is exposed not just from qemu_send_queue_xx(), so separating locks -- use NetQueue(NetQueue->lock) to protect the queue, and use nc->send_lock for the access of nc->peer so we can protect the sender from the remover.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: spread hub on AioContextshw/qdev-properties-system.c include/block/aio.h include/net/net.h +5 more+59 -53 replies
2/5net: hub use lock to protect ports listnet/hub.c+26 -11 reply
3/5net: introduce lock to protect NetQueuenet/queue.c+11 -00 replies
4/5net: introduce lock to protect NetClientState's peer's accessinclude/net/net.h net/hub.c net/net.c +1 more+97 -64 replies
5/5net: make netclient re-entrant with refcnthw/qdev-properties-system.c include/net/net.h net/hub.c +2 more+65 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/5] make netlayer re-entrant

From: Liu Ping Fan <[email protected]>

changes v1->v2
Because the NetQueue is exposed not just from qemu_send_queue_xx(), so separating locks -- use NetQueue(NetQueue->lock) to protect the queue, and use nc->send_lock for the access of nc->peer so we can protect the sender from the remover.

Question:
Use AioContexts for hub or the raw GSource

Liu Ping Fan (5):
net: spread hub on AioContexts
net: hub use lock to protect ports list
net: introduce lock to protect NetQueue
net: introduce lock to protect NetClientState's peer's access
net: make netclient re-entrant with refcnt

 hw/qdev-properties-system.c |   15 +++++
 include/block/aio.h         |    1 +
 include/net/net.h           |   12 ++++
 include/net/queue.h         |   14 +++++
 main-loop.c                 |    5 ++
 net/hub.c                   |   81 +++++++++++++++++++++++++++--
 net/net.c                   |  122 ++++++++++++++++++++++++++++++++++++++++--
 net/queue.c                 |   19 +++++--
 net/slirp.c                 |    3 +-
 9 files changed, 257 insertions(+), 15 deletions(-)
Signature · 1 line
1.7.4.4