qcow2: cache flush fixes and performance improvements
Status from this message: Thanks, applied all to the block branch.
Get series with b4
b4 am [email protected]Versions newest first
Changes in v2 from the cover letter
* Use qcow2_cache_set_dependency() in qcow2_alloc_bytes() instead of forcing a flush [Kevin]
* Add bdrv_flush() error code paths [Kevin]
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | qcow2: flush refcount cache correctly in alloc_refcount_block()block/ | +8 | 0 replies | |
| 2/6 | qcow2: flush refcount cache correctly in qcow2_write_snapshots()block/ | +4 | 0 replies | |
| 3/6 | qcow2: set L2 cache dependency in qcow2_alloc_bytes()block/ | +5 | 0 replies | |
| 4/6 | qcow2: flush in qcow2_update_snapshot_refcount()block/ block/ | +1 | 0 replies | |
| 5/6 | qcow2: drop flush in update_cluster_refcount()block/ | +0 | 0 replies | |
| 6/6 | qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()block/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Qemu-devel] [PATCH v2 0/6] qcow2: cache flush fixes and performance improvements
Users have reported that qcow2 internal snapshot creation is slow. I filed a bug report at https://bugs.launchpad.net/qemu/+bug/1126369.
This patch series reduces the time for qcow2 internal snapshot creation significantly, from more than 3 minutes to under 1 second.
In the process of removing unnecessary cache flushes, I also stumbled upon instances of bdrv_flush(bs->file) where we really want to flush metadata updates. Since qcow2 caches metadata this actually does not write out the metadata updates to disk! The fix is either bdrv_flush(bs) or a more specific cache flush (e.g. refcount block cache).
This series passes qemu-iotests.
v2:
* Use qcow2_cache_set_dependency() in qcow2_alloc_bytes() instead of forcing a flush [Kevin]
* Add bdrv_flush() error code paths [Kevin]
Stefan Hajnoczi (6):
qcow2: flush refcount cache correctly in alloc_refcount_block()
qcow2: flush refcount cache correctly in qcow2_write_snapshots()
qcow2: set L2 cache dependency in qcow2_alloc_bytes()
qcow2: flush in qcow2_update_snapshot_refcount()
qcow2: drop flush in update_cluster_refcount()
qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()
block/qcow2-refcount.c | 24 ++++++++++++++---------- block/qcow2-snapshot.c | 10 ++++------ 2 files changed, 18 insertions(+), 16 deletions(-)
Signature · 1 line
1.8.1.4