other ircomm_tty fixes (was Re: [PATCH] ircomm: release tty before sleeping potentially indefintely)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net/irda: Fix port open countsnet/ | +5 | 0 replies | |
| 2/4 | net/irda: Hold port lock while bumping blocked_opennet/ | +2 | 0 replies | |
| 3/4 | net/irda: Use barrier to set task statenet/ | +1 | 0 replies | |
| 4/4 | net/irda: Raise dtr in non-blocking opennet/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] other ircomm_tty fixes (was Re: [PATCH] ircomm: release tty before sleeping potentially indefintely)
Quoted 10 lines · Peter Hurley
Quoted 7 lines · David Miller
From: Peter Hurley <[email protected]>
Date: Sun, 03 Mar 2013 20:06:18 -0500Quoted 1 line
But regardless, this function
__cannot__sleep holding thetty_lock().So drop it across the
schedule(), but recheck the termios after regrabbing it.I'll have to do some research on that.
Still working on this...
Quoted 2 lines
In the meantime, while reviewing that code, I noticed there's a handful of serious bugs in that one function that I'll send a patchset for.
As promised.
Peter Hurley (4):
net/irda: Fix port open counts
net/irda: Hold port lock while bumping blocked_open net/irda: Use barrier to set task state net/irda: Raise dtr in non-blocking open
net/irda/ircomm/ircomm_tty.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-)
Signature · 1 line
1.8.1.2