Skip to content

other ircomm_tty fixes (was Re: [PATCH] ircomm: release tty before sleeping potentially indefintely)

Peter Hurley lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/irda: Fix port open countsnet/irda/ircomm/ircomm_tty.c+5 -90 replies
2/4net/irda: Hold port lock while bumping blocked_opennet/irda/ircomm/ircomm_tty.c+2 -20 replies
3/4net/irda: Use barrier to set task statenet/irda/ircomm/ircomm_tty.c+1 -10 replies
4/4net/irda: Raise dtr in non-blocking opennet/irda/ircomm/ircomm_tty.c+9 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] other ircomm_tty fixes (was Re: [PATCH] ircomm: release tty before sleeping potentially indefintely)
Quoted 10 lines · Peter Hurley
Quoted 7 lines · David Miller

From: Peter Hurley <[email protected]>
Date: Sun, 03 Mar 2013 20:06:18 -0500

Quoted 1 line

But regardless, this function __cannot__ sleep holding the tty_lock().

So drop it across the schedule(), but recheck the termios after regrabbing it.

I'll have to do some research on that.

Still working on this...

Quoted 2 lines

In the meantime, while reviewing that code, I noticed there's a handful of serious bugs in that one function that I'll send a patchset for.

As promised.

Peter Hurley (4):
net/irda: Fix port open counts
net/irda: Hold port lock while bumping blocked_open net/irda: Use barrier to set task state net/irda: Raise dtr in non-blocking open

 net/irda/ircomm/ircomm_tty.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)
Signature · 1 line
1.8.1.2