Skip to content

T HP support for PPC64

Aneesh Kumar K.V linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 6 repliesIn review

Changes from V1 from the cover letter

* Address review comments
* More patch split
* Add batch hpte invalidate for hugepages.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26powerpc: Use signed formatting when printing errorarch/powerpc/platforms/pseries/lpar.c+1 -10 replies
2/26powerpc: Save DAR and DSISR in pt_regs on MCEarch/powerpc/kernel/exceptions-64s.S arch/powerpc/xmon/xmon.c+10 -10 replies
3/26powerpc: Don't hard code the size of pte pagearch/powerpc/include/asm/pgtable.h arch/powerpc/mm/hash_low_64.S+8 -20 replies
4/26powerpc: Reduce the PTE_INDEX_SIZEarch/powerpc/include/asm/pgtable-ppc64-64k.h+2 -20 replies
5/26powerpc: Move the pte free routines from common headerarch/powerpc/include/asm/pgalloc-32.h arch/powerpc/include/asm/pgalloc-64.h arch/powerpc/include/asm/pgalloc.h+189 -590 replies
6/26powerpc: Reduce PTE table memory wastagearch/powerpc/include/asm/mmu-book3e.h arch/powerpc/include/asm/mmu-hash64.h arch/powerpc/include/asm/page.h +4 more+264 -580 replies
7/26powerpc: Add size argument to pgtable_cache_addarch/powerpc/include/asm/pgtable-ppc64.h arch/powerpc/mm/init_64.c+8 -33 replies
8/26powerpc: Clarify __pgtable_cache_add by renaming shift to indexarch/powerpc/include/asm/pgtable-ppc64.h arch/powerpc/mm/init_64.c+9 -90 replies
9/26powerpc: Use encode avpn where we need only avpn valuesarch/powerpc/mm/hash_native_64.c arch/powerpc/platforms/cell/beat_htab.c arch/powerpc/platforms/ps3/htab.c+10 -100 replies
10/26powerpc: Decode the pte-lp-encoding bits correctly.arch/powerpc/include/asm/machdep.h arch/powerpc/include/asm/mmu-hash64.h arch/powerpc/kvm/book3s_hv.c +7 more+208 -1141 reply
11/26powerpc: Fix hpte_decode to use the correct decoding for page sizesarch/powerpc/mm/hash_native_64.c+22 -151 reply
12/26powerpc: Return all the valid pte ecndoing in KVM_PPC_GET_SMMU_INFO ioctlarch/powerpc/kvm/book3s_hv.c+9 -21 reply
13/26powerpc: Update tlbie/tlbiel as per ISA docarch/powerpc/mm/hash_native_64.c+40 -120 replies
14/26powerpc: print both base and actual page size on hash failurearch/powerpc/include/asm/mmu-hash64.h arch/powerpc/mm/hash_utils_64.c arch/powerpc/mm/hugetlbpage-hash64.c+10 -70 replies
15/26powerpc: Print page size info during bootarch/powerpc/mm/hash_utils_64.c+5 -50 replies
16/26mm/THP: HPAGE_SHIFT is not a #define on some archinclude/linux/huge_mm.h mm/huge_memory.c+6 -60 replies
17/26mm/THP: Add pmd args to pgtable deposit and withdraw APIsarch/s390/include/asm/pgtable.h arch/s390/mm/pgtable.c arch/sparc/include/asm/pgtable_64.h +4 more+27 -210 replies
18/26mm/THP: withdraw the pgtable after pmdp related operationsmm/huge_memory.c+2 -10 replies
19/26powerpc/THP: Implement transparent huge pages for ppc64arch/powerpc/include/asm/page.h arch/powerpc/include/asm/pgtable-ppc64-64k.h arch/powerpc/include/asm/pgtable-ppc64.h +5 more+597 -30 replies
20/26powerpc/THP: Differentiate THP PMD entries from HUGETLB PMD entriesarch/powerpc/include/asm/pgtable.h arch/powerpc/mm/pgtable.c arch/powerpc/mm/pgtable_64.c+17 -50 replies
21/26powerpc/THP: Add code to handle HPTE faults for large pagesarch/powerpc/include/asm/kvm_book3s_64.h arch/powerpc/include/asm/mmu-hash64.h arch/powerpc/include/asm/pgtable-ppc64.h +11 more+283 -420 replies
22/26powerpc: Handle huge page in perf callchainarch/powerpc/perf/callchain.c+21 -110 replies
23/26powerpc/THP: hypervisor require few WIMG bit setarch/powerpc/mm/hugepage-hash64.c+2 -00 replies
24/26powerpc/THP: get_user_pages_fast changesarch/powerpc/mm/gup.c+82 -20 replies
25/26powerpc/THP: Enable THP on PPC64arch/powerpc/include/asm/pgtable.h+28 -20 replies
26/26powerpc: Optimize hugepage invalidatearch/powerpc/include/asm/machdep.h arch/powerpc/mm/hash_native_64.c arch/powerpc/mm/pgtable.c +1 more+210 -100 replies

Reviews trailers per patch

7 of 26 patches have a Reviewed-by or Acked-by.

PatchPaul Mackerras
1/26A-b
2/26A-b
3/26A-b
4/26A-b
5/26A-b
6/26
7/26
8/26
9/26A-b
10/26
11/26A-b
12/26
13/26
14/26
15/26
16/26
17/26
18/26
19/26
20/26
21/26
22/26
23/26
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -V2 00/26]T HP support for PPC64

Hi,

This patchset adds transparent huge page support for PPC64.

TODO:
* ppc64 KVM related changes
* powernv still doesn't boot
* hash preload support in update_mmu_cache_pmd

Some numbers:

The latency measurements code from Anton found at
http://ozlabs.org/~anton/junkcode/latency2001.c

THP disabled 64K page size
------------------------
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 731.73 cycles 205.77 ns
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 743.39 cycles 209.05 ns
[root@llmp24l02 ~]#

THP disabled large page via hugetlbfs
-------------------------------------
[root@llmp24l02 ~]# ./latency2001 -l 8G
8589934592 416.09 cycles 117.01 ns
[root@llmp24l02 ~]# ./latency2001 -l 8G
8589934592 415.74 cycles 116.91 ns

THP enabled 64K page size.
----------------
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 405.07 cycles 113.91 ns
[root@llmp24l02 ~]# ./latency2001 8G
8589934592 411.82 cycles 115.81 ns
[root@llmp24l02 ~]#

We are close to hugetlbfs in latency and we can achieve this with zero config/page reservation. Most of the allocations above are fault allocated. I haven't really measured the collapse alloc impact.

Another test that does 50000000 random access over 1GB area goes from 2.65 seconds to 1.07 seconds with this patchset.

Changes from V1
* Address review comments
* More patch split
* Add batch hpte invalidate for hugepages.

Changes from RFC V2:
* Address review comments
* More code cleanup and patch split

Changes from RFC V1:
* HugeTLB fs now works
* Compile issues fixed
* rebased to v3.8
* Patch series reorded so that ppc64 cleanups and MM THP changes are moved early in the series. This should help in picking those patches early.

Thanks,
-aneesh