Skip to content

Bluetooth: Management interface fixes

Johan Hedberg linux-bluetooth 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest26 patches 1 replyIn review
  2. v426 patches 5 repliesSuperseded
  3. v36 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches0 repliesSuperseded
v15 patches0 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26Bluetooth: Move power on HCI command updates to their own functionnet/bluetooth/mgmt.c+42 -360 replies
2/26Bluetooth: Update mgmt powered HCI commands to use async requestsnet/bluetooth/mgmt.c+100 -630 replies
3/26Bluetooth: Wait for HCI command completion with mgmt_set_powerednet/bluetooth/mgmt.c+34 -120 replies
4/26Bluetooth: Fix busy condition testing for EIR and class updatesnet/bluetooth/mgmt.c+36 -90 replies
5/26Bluetooth: Fix UUID/class mgmt command response synchronizationnet/bluetooth/mgmt.c+56 -170 replies
6/26Bluetooth: Remove useless HCI_PENDING_CLASS flaginclude/net/bluetooth/hci.h net/bluetooth/hci_event.c net/bluetooth/mgmt.c+1 -70 replies
7/26Bluetooth: Add a define for the HCI persistent flags maskinclude/net/bluetooth/hci.h net/bluetooth/hci_event.c+6 -10 replies
8/26Bluetooth: Clear non-persistent flags when closing HCI devicenet/bluetooth/hci_core.c+1 -00 replies
9/26Bluetooth: Fix clearing flags on power off before notifying mgmtnet/bluetooth/hci_core.c+4 -40 replies
10/26Bluetooth: Fix waiting for EIR update when setting local namenet/bluetooth/mgmt.c+49 -470 replies
11/26Bluetooth: Handle AD updating through an async requestinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/hci_event.c+21 -310 replies
12/26Bluetooth: Fix local name setting for LE-only controllersnet/bluetooth/mgmt.c+9 -20 replies
13/26Bluetooth: Fix setting local name to the existing valuenet/bluetooth/mgmt.c+11 -00 replies
14/26Bluetooth: Use an async request for mgmt_set_connectablenet/bluetooth/mgmt.c+29 -80 replies
15/26Bluetooth: Fix fast connectable response sendingnet/bluetooth/mgmt.c+42 -110 replies
16/26Bluetooth: Limit fast connectable support to >= 1.2 controllersnet/bluetooth/mgmt.c+3 -20 replies
17/26Bluetooth: Fix error response for simultaneous fast connectable commandsnet/bluetooth/mgmt.c+6 -00 replies
18/26Bluetooth: Add proper flag for fast connectable modeinclude/net/bluetooth/hci.h net/bluetooth/mgmt.c+19 -10 replies
19/26Bluetooth: Refactor fast connectable HCI commandsnet/bluetooth/mgmt.c+24 -190 replies
20/26Bluetooth: Disable fast connectable when disabling connectablenet/bluetooth/mgmt.c+3 -00 replies
21/26Bluetooth: Add reading of page scan parametersinclude/net/bluetooth/hci.h include/net/bluetooth/hci_core.h net/bluetooth/hci_core.c +1 more+55 -00 replies
22/26Bluetooth: Update page scan parameters after successful write commandsnet/bluetooth/hci_event.c+43 -00 replies
23/26Bluetooth: Fix updating page scan parameters when not necessarynet/bluetooth/mgmt.c+8 -20 replies
24/26Bluetooth: Fix fast connectable state when enabling page scannet/bluetooth/mgmt.c+16 -10 replies
25/26Bluetooth: Simplify address parameters of user_pairing_resp()net/bluetooth/mgmt.c+14 -130 replies
26/26Bluetooth: Fix PIN/Confirm/Passkey response parametersnet/bluetooth/mgmt.c+12 -81 reply

Reviews trailers per patch

All 26 patches have a Reviewed-by or Acked-by.

PatchMarcel Holtmann
1/26A-b
2/26A-b
3/26A-b
4/26A-b
5/26A-b
6/26A-b
7/26A-b
8/26A-b
9/26A-b
10/26A-b
11/26A-b
12/26A-b
13/26A-b
14/26A-b
15/26A-b
16/26A-b
17/26A-b
18/26A-b
19/26A-b
20/26A-b
21/26A-b
22/26A-b
23/26A-b
24/26A-b
25/26A-b
26/26A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/26] Bluetooth: Management interface fixes

Hi,

Here's hopefully the last send of this set. v5 includes the flags mask fix suggested by Marcel as well as updates to all those patches that the mask inversion affects.

Johan

----------------------------------------------------------------
Johan Hedberg (26):
Bluetooth: Move power on HCI command updates to their own function
Bluetooth: Update mgmt powered HCI commands to use async requests
Bluetooth: Wait for HCI command completion with mgmt_set_powered
Bluetooth: Fix busy condition testing for EIR and class updates
Bluetooth: Fix UUID/class mgmt command response synchronization
Bluetooth: Remove useless HCI_PENDING_CLASS flag
Bluetooth: Add a define for the HCI persistent flags mask
Bluetooth: Clear non-persistent flags when closing HCI device
Bluetooth: Fix clearing flags on power off before notifying mgmt
Bluetooth: Fix waiting for EIR update when setting local name
Bluetooth: Handle AD updating through an async request
Bluetooth: Fix local name setting for LE-only controllers
Bluetooth: Fix setting local name to the existing value
Bluetooth: Use an async request for mgmt_set_connectable
Bluetooth: Fix fast connectable response sending
Bluetooth: Limit fast connectable support to >= 1.2 controllers
Bluetooth: Fix error response for simultaneous fast connectable commands
Bluetooth: Add proper flag for fast connectable mode
Bluetooth: Refactor fast connectable HCI commands
Bluetooth: Disable fast connectable when disabling connectable
Bluetooth: Add reading of page scan parameters
Bluetooth: Update page scan parameters after successful write commands
Bluetooth: Fix updating page scan parameters when not necessary
Bluetooth: Fix fast connectable state when enabling page scan
Bluetooth: Simplify address parameters of user_pairing_resp()
Bluetooth: Fix PIN/Confirm/Passkey response parameters

 include/net/bluetooth/hci.h      |   21 +-
 include/net/bluetooth/hci_core.h |    8 +-
 net/bluetooth/hci_core.c         |   42 ++-
 net/bluetooth/hci_event.c        |   97 +++++-
 net/bluetooth/mgmt.c             |  680 ++++++++++++++++++++++++++------------
 5 files changed, 599 insertions(+), 249 deletions(-)