n_tty fixes

Peter Hurley linux-serial lkml 2 versions Mar 6, 2013 – Jun 15, 2013 In review

Get series with b4

b4 am [email protected]

Versions newest first · linked by author and title

v1 Latest posting 2/2 Jun 15, 20134 patches 1 replyIn review
v1 posting 1/2 Mar 6, 20137 patches 5 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#	Subject and files	Size	Replies
1/4	n_tty: Encapsulate minimum_to_wake within N_TTY`drivers/tty/n_tty.c` `drivers/tty/tty_io.c` `include/linux/tty.h` +1 more	+42 ~~-21~~	0 replies
2/4	n_tty: Untangle read completion variables`drivers/tty/n_tty.c`	+2 -6	0 replies
3/4	n_tty: Fix unsafe update of available buffer space`drivers/tty/n_tty.c`	+11 -7	0 replies
4/4	n_tty: Buffer work should not reschedule itself`drivers/tty/n_tty.c`	+9 -4	0 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] [resend] n_tty fixes

Quoted 19 lines · Peter Hurley

Quoted 19 lines · Greg Kroah-Hartman
Quoted 17 lines · Peter Hurley
Quoted 9 lines
minimum_to_wake is unique to N_TTY processing, and belongs in per-ldisc data.
Add the ldisc method, ldisc_ops::fasync(), to notify line disciplines when signal-driven I/O is enabled or disabled. When enabled for N_TTY (by fcntl(F_SETFL, O_ASYNC)), blocking reader/polls will be woken for any readable input. When disabled, blocking reader/polls are not woken until the read buffer is full.
Quoted 4 lines
Canonical mode (L_ICANON(tty), n_tty_data::icanon) is not affected by the minimum_to_wake setting.
Signed-off-by Peter Hurley <[email protected]>
For some reason, this patch doesn't apply. Care to refresh this one, and the rest in this series, and resend?

Quoted 7 lines

Quoted 4 lines
Sorry. There was probably some accidental dependency on one of the other patchsets of mine you did apply.
This and patch 5 now apply without error to tty-next.
Ok, but they are now long gone from my queue. Can you please resend what I haven't applied?

Greg,

I resent these back on 19 Mar but they never got applied. (maybe because I resent them as 4,5,6 & 7/7 ??)

Anyway, these apply cleanly to tty-next.

Regards,
Peter Hurley

Peter Hurley (4):
n_tty: Encapsulate minimum_to_wake within N_TTY
n_tty: Untangle read completion variables
n_tty: Fix unsafe update of available buffer space
n_tty: Buffer work should not reschedule itself

 drivers/tty/n_tty.c       | 76 ++++++++++++++++++++++++++++++-----------------
 drivers/tty/tty_io.c      | 17 ++++++-----
 include/linux/tty.h       |  1 -
 include/linux/tty_ldisc.h |  6 ++++
 4 files changed, 63 insertions(+), 37 deletions(-)

Signature · 1 line

1.8.1.2

Read the cover letter in its thread