Skip to content

x86/mm: out-of-memory errors in p2m ops

Tim Deegan xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5x86/mm: use bool_t for flags in shadow-pagetable structsxen/include/asm-x86/domain.h+11 -110 replies
2/5x86/mm: warn if we ever run out of shadow/hap pool for p2m/lgd ops.xen/arch/x86/mm/hap/hap.c xen/arch/x86/mm/shadow/common.c xen/include/asm-x86/domain.h+15 -12 replies
3/5x86/ept: check for errors in a few callers of ept_set_entry.xen/arch/x86/mm/p2m-ept.c+15 -50 replies
4/5x86/mem_sharing: check for errors in p2m->set_entry().xen/arch/x86/mm/mem_sharing.c+8 -43 replies
5/5x86/mem_access: check for errors in p2m->set_entry().xen/arch/x86/mm/p2m.c+18 -71 reply

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndres Lagar-CavillaJan BeulichAravindh Puthiyaparambil
SeriesA-b
1/5
2/5
3/5
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] x86/mm: out-of-memory errors in p2m ops

These patches begin to address error handling when the shadow/hap pool can't allocate any more p2m pages.

Patch 1 is a bit of preliminary tidying.
Patch 2 prints a warning on error so it can be diagnosed. Patches 3-5 add checks to direct callers of the p2m allocation functions.

With these patches applied, pool allocation errors will be propagated as far as the set_p2m_entry() interface. Unfortunately there are many callers of that that don't check the return code -- PoD and mem_paging are the major cuplrits, but there are other cases where the error is discarded further up the stack (e.g. some callers of set_mmio_p2m_entry()). Chasing those up is work for another day.

Cheers,

Tim.