Skip to content

ARM: at91: fix hanged boot

Johan Hovold linux-arm-kernel lkml stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v25 patches 4 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

v2 from the cover letter

- add DT-support
- make sys_irq_mask non-mandatory

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ARM: at91: fix hanged boot due to early rtc-interruptarch/arm/mach-at91/Makefile arch/arm/mach-at91/at91sam9g45.c arch/arm/mach-at91/at91sam9n12.c +8 more+86 -11 reply
2/3ARM: at91: fix hanged boot due to early rtt-interruptarch/arm/mach-at91/at91sam9260.c arch/arm/mach-at91/at91sam9261.c arch/arm/mach-at91/at91sam9263.c +4 more+34 -01 reply
3/3ARM: at91/rtc: disable interrupts at shutdowndrivers/rtc/rtc-at91rm9200.c+9 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNicolas Ferre
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] ARM: at91: fix hanged boot

These patches fix a few severe issues affecting most AT91 SOCs where boot can hang after a non-general reset, and where the only way to get the system booting again is to do a general reset -- something which could require physically removing any backup battery.

The problems stem from the fact that the RTC and RTT-peripherals are powered by backup power (VDDBU) and are not reset on wake-up, user, watchdog or software reset. Consequently, RTC and RTT-alarms and their interrupts may be enabled at boot, leading to a system lock-up when an interrupt arrives on the shared system-interrupt line before the appropriate handler (e.g. RTC-driver) has been installed.

The easiest way to trigger this is to simply wake up from an RTC-alarm on at91sam9g45. The RTC-driver currently does not disable interrupts at shutdown so even after a clean shut-down the system will always hang after waking up.

The more general problem can be triggered, for example, by doing a user-reset while updating the RTC-time or if an RTC or RTT-alarm goes off after a non-clean shutdown.

To fix this I add two helper functions to be called called by arch-code to mask the relevant interrupts before enabling the system interrupt at early boot.

The patches have been tested on at91sam9g45 and compile-tested for the other SOCs.

Johan

v2:
- add DT-support
- make sys_irq_mask non-mandatory

v3
- rebase on v3.12-rc5
- drop DT-support (interrupt masking is needed even if RTC or RTT nodes are missing)
- drop dedicated SOC-initialiser and call helpers directly from init
- drop revert-patch of move of RTC-register definitions to drivers/ and copy the two needed definitions instead
- move helper functions from setup.c to a separate file
- add fix for new sama5d3 SOC
- add a register read back to make sure write has reached the devices
- split fix in two patches for RTC and RTT, respectively

Johan Hovold (3):
ARM: at91: fix hanged boot due to early rtc-interrupt
ARM: at91: fix hanged boot due to early rtt-interrupt
ARM: at91/rtc: disable interrupts at shutdown

 arch/arm/mach-at91/Makefile                   |  2 +-
 arch/arm/mach-at91/at91sam9260.c              |  2 +
 arch/arm/mach-at91/at91sam9261.c              |  2 +
 arch/arm/mach-at91/at91sam9263.c              |  3 ++
 arch/arm/mach-at91/at91sam9g45.c              |  3 ++
 arch/arm/mach-at91/at91sam9n12.c              |  6 +++
 arch/arm/mach-at91/at91sam9rl.c               |  3 ++
 arch/arm/mach-at91/at91sam9x5.c               |  6 +++
 arch/arm/mach-at91/generic.h                  |  2 +
 arch/arm/mach-at91/include/mach/at91sam9n12.h |  5 ++
 arch/arm/mach-at91/include/mach/at91sam9x5.h  |  5 ++
 arch/arm/mach-at91/include/mach/sama5d3.h     |  5 ++
 arch/arm/mach-at91/sama5d3.c                  |  6 +++
 arch/arm/mach-at91/sysirq_mask.c              | 71 +++++++++++++++++++++++++++
 drivers/rtc/rtc-at91rm9200.c                  |  9 ++++
 15 files changed, 129 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/mach-at91/sysirq_mask.c
Signature · 1 line
1.8.4