Skip to content

RFC bttv: fix muting/unmuting on probing, first open and last close

Frank Schäfer linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest6 patches 3 repliesIn review

Changes in v2 from the cover letter

- splitted patch 1 to 4 separate patches (patches 1-4)
- dropped patch 2 (mute on last close of the radio device node)
- added patches 5+6

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bttv: audio_mux() use a local variable "gpio_mute" instead of modifying the function parameter "mute"drivers/media/pci/bt8xx/bttv-driver.c+4 -41 reply
2/6bttv: audio_mux(): do not change the value of the v4l2 mute controldrivers/media/pci/bt8xx/bttv-driver.c+4 -42 replies
3/6bttv: fix mute on last close of the video device nodedrivers/media/pci/bt8xx/bttv-driver.c+1 -10 replies
4/6bttv: do not unmute the device before the first opendrivers/media/pci/bt8xx/bttv-driver.c+5 -30 replies
5/6bttv: avoid mute on last close when the radio device node is still opendrivers/media/pci/bt8xx/bttv-driver.c+4 -20 replies
6/6bttv: radio: apply mute settings on opendrivers/media/pci/bt8xx/bttv-driver.c+2 -00 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchHans Verkuil
1/6A-b
2/6A-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 0/6] bttv: fix muting/unmuting on probing, first open and last close

This patch series fixes some remaining issues with regards to device muting/unmuting on probing, first open and last close with the bttv driver.

The first 2 patches are preparatory patches, patches 3 to 6 the actual fixes.

Changes since v1:
- splitted patch 1 to 4 separate patches (patches 1-4)
- dropped patch 2 (mute on last close of the radio device node)
- added patches 5+6

Frank Schäfer (6):
bttv: audio_mux() use a local variable "gpio_mute" instead of
modifying the function parameter "mute"
bttv: audio_mux(): do not change the value of the v4l2 mute control
bttv: fix mute on last close of the video device node
bttv: do not unmute the device before the first open
bttv: avoid mute on last close when the radio device node is still
open
bttv: radio: apply mute settings on open

 drivers/media/pci/bt8xx/bttv-driver.c |   34 +++++++++++++++++++--------------

1 Datei geändert, 20 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-)

Signature · 1 line
1.7.10.4