Skip to content

xfree86: Handle drm race condition

Bryce Harrington dri-devel intel-gfx 2 versions – NAK

Status from this message: Nacked-by: Maarten Lankhorst <[email protected]>

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 12 repliesNAK
  2. v18 patches 2 repliesSuperseded

Patches in v2

#Subject and filesSizeRepliesApplied
1/7xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.hw/xfree86/os-support/linux/lnx_platform.c+1 -00 replies
2/7xfree86: Track error code and add label for error handling.hw/xfree86/os-support/linux/lnx_platform.c+6 -40 replies
3/7xfree86: Provide more details on failurehw/xfree86/os-support/linux/lnx_platform.c+3 -10 replies
4/7xfree86: Keep trying to set interface on drm for 2 seconds.hw/xfree86/os-support/linux/lnx_platform.c+15 -50 replies
5/7xfree86: Fix race condition failure opening drm.hw/xfree86/os-support/linux/lnx_platform.c+6 -00 replies
6/7xfree86: Be verbose if waiting on opening the drm devicehw/xfree86/os-support/linux/lnx_platform.c+4 -10 replies
7/7xfree86: Also handle EAGAIN errors from drmSetInterfaceVersion().hw/xfree86/os-support/linux/lnx_platform.c+3 -00 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChris WilsonMaarten Lankhorst
SeriesR-b Nacked-by
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] xfree86: Handle drm race condition

Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.

----
When starting up (on Ubuntu), X can hit an error trying to set the version on the drm device. We believe this is a race with plymouth (or the kernel), since adding some delay to the boot results in a functioning session for affected users.

So far we have not found a reliable way to reproduce the bug synthetically. It appears to affect users on fast booting hardware (e.g. SSDs) when using the Intel graphics driver.

We have not root-caused the bug yet. Currently we suspect the actual breakage is underneath X (plymouth/lightdm/kernel), and are still experimenting. However, this patch does seem to improve things for users, so it or parts of it may be worth your consideration for inclusion in xserver.

I'm including the patch broken down into easily pickable chunks. Note the final patch in the series is highly optional; it handles EAGAIN being passed from the ioctl - which looks impossible to happen in practice.

https://bugs.launchpad.net/ubuntu/+source/libdrm/+bug/982889

Bryce Harrington (7):
xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.
xfree86: Track error code and add label for error handling.
xfree86: Provide more details on failure
xfree86: Keep trying to set interface on drm for 2 seconds.
xfree86: Fix race condition failure opening drm.
xfree86: Be verbose if waiting on opening the drm device
xfree86: Also handle EAGAIN errors from drmSetInterfaceVersion().

 hw/xfree86/os-support/linux/lnx_platform.c |   43 ++++++++++++++++++++++------
 1 file changed, 35 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.9.5