Skip to content

virtqueue_add_sgs, virtqueue_add_outbuf, virtqueue_add_inbuf

Rusty Russell virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22scatterlist: introduce sg_unmark_endblock/blk-integrity.c block/blk-merge.c include/linux/scatterlist.h+18 -20 replies
2/22virtio_ring: virtqueue_add_sgs, to add multiple sgs.drivers/virtio/virtio_ring.c include/linux/virtio.h tools/virtio/linux/scatterlist.h +1 more+132 -420 replies
3/22virtio_ring: don't count elements twice for add_buf path.drivers/virtio/virtio_ring.c+80 -670 replies
4/22virtio_ring: inline internal vring functions more aggressively.drivers/virtio/virtio_ring.c+56 -350 replies
5/22virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.drivers/virtio/virtio_ring.c include/linux/virtio.h+54 -00 replies
6/22tools/virtio: make vringh_test use inbuf/outbuf.tools/virtio/linux/virtio.h tools/virtio/vringh_test.c+14 -40 replies
7/22virtio-blk: reorganize virtblk_add_reqdrivers/block/virtio_blk.c+20 -350 replies
8/22virtio-blk: use virtqueue_add_sgs on bio pathdrivers/block/virtio_blk.c+29 -290 replies
9/22virtio-blk: use virtqueue_add_sgs on req pathdrivers/block/virtio_blk.c+33 -360 replies
10/22virtio_blk: remove nents member.drivers/block/virtio_blk.c+11 -110 replies
11/22virtio-scsi: use virtqueue_add_sgs for command buffersdrivers/scsi/virtio_scsi.c+34 -575 replies
12/22virtio_scsi: use virtqueue_add_inbuf() for virtscsi_kick_event.drivers/scsi/virtio_scsi.c+2 -21 reply
13/22virtio_net: use virtqueue_add_sgs[] for command buffers.drivers/net/virtio_net.c+25 -253 replies
14/22virtio_net: use simplified virtqueue accessors.drivers/net/virtio_net.c+5 -61 reply
15/22virtio_rng: use simplified virtqueue accessors.drivers/char/hw_random/virtio-rng.c+1 -11 reply
16/22virtio_console: use simplified virtqueue accessors.drivers/char/virtio_console.c+3 -31 reply
17/22caif_virtio: use simplified virtqueue accessors.drivers/net/caif/caif_virtio.c+1 -20 replies
18/22virtio_rpmsg_bus: use simplified virtqueue accessors.drivers/rpmsg/virtio_rpmsg_bus.c+4 -42 replies
19/22virtio_balloon: use simplified virtqueue accessors.drivers/virtio/virtio_balloon.c+3 -30 replies
20/229p/trans_virtio.c: use virtio_add_sgs[]net/9p/trans_virtio.c+39 -91 reply
21/22tools/virtio: remove virtqueue_add_buf() from tests.tools/virtio/linux/virtio.h tools/virtio/virtio_test.c tools/virtio/vringh_test.c+15 -200 replies
22/22virtio: remove virtqueue_add_buf().drivers/virtio/virtio_ring.c include/linux/virtio.h+0 -380 replies

Reviews trailers per patch

13 of 22 patches have a Reviewed-by or Acked-by.

PatchJens AxboeWanlong GaoAsias HePaolo BonziniAmit ShahOhad Ben-Cohen
1/22A-b
2/22R-b R-b
3/22R-b
4/22
5/22
6/22
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b R-b R-b A-b A-b R-b
12/22R-b
13/22T-b
14/22R-b
15/22R-b
16/22A-b
17/22
18/22A-b
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] virtqueue_add_sgs, virtqueue_add_outbuf, virtqueue_add_inbuf

Add virtqueue_add_sgs which is more general than virtqueue_add_buf, which makes virtio-scsi and virtio-blk nicer, then add virtqueue_add_inbuf and virtqueue_add_outbuf which handle the more general case, and finally delete virtqueue_add_buf().

I'm hoping this will be the final post of the whole series, and it can move from my pending-rebases tree into virtio-next.

Thanks!
Rusty.

Paolo Bonzini (4):
scatterlist: introduce sg_unmark_end
virtio-blk: reorganize virtblk_add_req
virtio-blk: use virtqueue_add_sgs on bio path
virtio-blk: use virtqueue_add_sgs on req path

Rusty Russell (17):
virtio_ring: virtqueue_add_sgs, to add multiple sgs.
virtio_ring: don't count elements twice for add_buf path.
virtio_ring: inline internal vring functions more aggressively.
virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf. tools/virtio: make vringh_test use inbuf/outbuf.
virtio_blk: remove nents member.
virtio_scsi: use virtqueue_add_inbuf() for virtscsi_kick_event.
virtio_net: use virtqueue_add_sgs[] for command buffers.
virtio_net: use simplified virtqueue accessors.
virtio_rng: use simplified virtqueue accessors.
virtio_console: use simplified virtqueue accessors.
caif_virtio: use simplified virtqueue accessors.
virtio_rpmsg_bus: use simplified virtqueue accessors.
virtio_balloon: use simplified virtqueue accessors. 9p/trans_virtio.c: use virtio_add_sgs[]
tools/virtio: remove virtqueue_add_buf() from tests.
virtio: remove virtqueue_add_buf().

Wanlong Gao (1):
virtio-scsi: use virtqueue_add_sgs for command buffers

 block/blk-integrity.c               |    2 +-
 block/blk-merge.c                   |    2 +-
 drivers/block/virtio_blk.c          |  146 ++++++++++------------
 drivers/char/hw_random/virtio-rng.c |    2 +-
 drivers/char/virtio_console.c       |    6 +-
 drivers/net/caif/caif_virtio.c      |    3 +-
 drivers/net/virtio_net.c            |   61 +++++----
 drivers/rpmsg/virtio_rpmsg_bus.c    |    8 +-
 drivers/scsi/virtio_scsi.c          |   95 ++++++--------
 drivers/virtio/virtio_balloon.c     |    6 +-
 drivers/virtio/virtio_ring.c        |  235 +++++++++++++++++++++++++----------
 include/linux/scatterlist.h         |   16 +++
 include/linux/virtio.h              |   18 ++-
 net/9p/trans_virtio.c               |   48 +++++--
 tools/virtio/linux/scatterlist.h    |   16 +++
 tools/virtio/linux/virtio.h         |   18 ++-
 tools/virtio/virtio_test.c          |    6 +-
 tools/virtio/vringh_test.c          |   30 ++---
 18 files changed, 433 insertions(+), 285 deletions(-)
Signature · 1 line
1.7.10.4