ccid and libcacard fixes for windows/mingw
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest28 patches 3 repliesIn review
- v210 patches 2 repliesSuperseded
- v126 patches 21 repliesSuperseded
Changes in v3 from the cover letter
resend all the series per Marc Andre's request.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/28 | libcacard: correct T0 historical bytes sizelibcacard/ | +1 | 0 replies | |
| 2/28 | ccid-card-emul: do not crash if backend is not providedhw/ | +3 | 0 replies | |
| 3/28 | ccid: make backend_enum_table "static const" and adjust usershw/ | +3 | 0 replies | |
| 4/28 | ccid: declare DEFAULT_ATR table to be "static const"hw/ | +1 | 0 replies | |
| 5/28 | libcacard: use system config directory for nss db on win32libcacard/ | +17 | 0 replies | |
| 6/28 | util: move socket_init() to osdep.cutil/ util/ | +23 | 0 replies | |
| 7/28 | build-sys: must link with -fstack-protectorconfigure rules.mak | +8 | 1 reply | |
| 8/28 | libcacard: fix mingw64 cross-compilationMakefile rules.mak | +8 | 0 replies | |
| 9/28 | libcacard: split vscclient main() from socket readinglibcacard/ | +162 | 0 replies | |
| 10/28 | libcacard: vscclient to use QemuThread for portabilitylibcacard/ | +2 | 0 replies | |
| 11/28 | libcacard: teach vscclient to use GMainLoop for portabilitylibcacard/ | +246 | 1 reply | |
| 12/28 | libcacard: remove sql: prefixlibcacard/ | +2 | 0 replies | |
| 13/28 | libcacard: remove default libcoolkey loadinglibcacard/ | +1 | 0 replies | |
| 14/28 | dev-smartcard-reader: white space fixeshw/ | +4 | 0 replies | |
| 15/28 | dev-smartcard-reader: nicer debug messageshw/ | +63 | 0 replies | |
| 16/28 | dev-smartcard-reader: remove aborts (never triggered, but just in case)hw/ | +12 | 0 replies | |
| 17/28 | dev-smartcard-reader: support windows guesthw/ | +2 | 0 replies | |
| 18/28 | dev-smartcard-reader: reuse usb.h definitionshw/ | +5 | 0 replies | |
| 19/28 | libcacard: change default ATRlibcacard/ | +10 | 0 replies | |
| 20/28 | ccid-card-passthru: add atr checkhw/ | +59 | 0 replies | |
| 21/28 | ccid-card-passthru, dev-smartcard-reader: add debug environment variableshw/ hw/ include/ +1 more | +31 | 0 replies | |
| 22/28 | dev-smartcard-reader: define structs for CCID_Parameter internalshw/ | +47 | 0 replies | |
| 23/28 | dev-smartcard-reader: change default protocol to T=0hw/ | +3 | 0 replies | |
| 24/28 | dev-smartcard-reader: copy atr protocol to ccid parametershw/ | +45 | 0 replies | |
| 25/28 | libcacard/vreader: add debugging messages for apdulibcacard/ libcacard/ libcacard/ | +85 | 0 replies | |
| 26/28 | libcacard: move atr setting from macro to functionMakefile.objs libcacard/ libcacard/ +2 more | +58 | 0 replies | |
| 27/28 | dev-smartcard-reader: empty implementation for Mechanical (fail correctly)hw/ | +4 | 0 replies | |
| 28/28 | libcacard/cac: change big switch functions to single return pointlibcacard/ | +52 | 0 replies |
Reviews trailers per patch
None of the 28 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marc-André Lureau |
|---|---|
| Series | R-b |
| 1/28 | |
| 2/28 | |
| 3/28 | |
| 4/28 | |
| 5/28 | |
| 6/28 | |
| 7/28 | |
| 8/28 | |
| 9/28 | |
| 10/28 | |
| 11/28 | |
| 12/28 | |
| 13/28 | |
| 14/28 | |
| 15/28 | |
| 16/28 | |
| 17/28 | |
| 18/28 | |
| 19/28 | |
| 20/28 | |
| 21/28 | |
| 22/28 | |
| 23/28 | |
| 24/28 | |
| 25/28 | |
| 26/28 | |
| 27/28 | |
| 28/28 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 00/28] ccid and libcacard fixes for windows/mingw
This series:
1. fixes windows guests to show the ccid device
2. changes libcacard to use glib
3. makes libcacard build under mingw
4. does some cleanups
It contains a few patches already posted to the list (the two Jim Meyering patches) which were already acked.
I'll make a pull request once this had some time to be reviewed.
Tested with a fedora and windows 7 guest.
The main non cleanup patches are:
hw/usb/dev-smartcard-reader: support windows guest
libcacard: correct T0 historical bytes size
v3:
resend all the series per Marc Andre's request.
v2:
only resent patches that were not acked before.
did all the changes per Marc Andre's comments. Please look at the g_debug one, I'm not sure about the ifdeffery there (not if it works, but if it looks ok).
Alon Levy (15):
dev-smartcard-reader: white space fixes
dev-smartcard-reader: nicer debug messages
dev-smartcard-reader: remove aborts (never triggered, but just in
case)
dev-smartcard-reader: support windows guest
dev-smartcard-reader: reuse usb.h definitions
libcacard: change default ATR
ccid-card-passthru: add atr check
ccid-card-passthru, dev-smartcard-reader: add debug environment
variables
dev-smartcard-reader: define structs for CCID_Parameter internals
dev-smartcard-reader: change default protocol to T=0
dev-smartcard-reader: copy atr protocol to ccid parameters libcacard/vreader: add debugging messages for apdu
libcacard: move atr setting from macro to function
dev-smartcard-reader: empty implementation for Mechanical (fail
correctly)
libcacard/cac: change big switch functions to single return point
Jim Meyering (2):
ccid: make backend_enum_table "static const" and adjust users
ccid: declare DEFAULT_ATR table to be "static const"
Marc-André Lureau (11):
libcacard: correct T0 historical bytes size
ccid-card-emul: do not crash if backend is not provided
libcacard: use system config directory for nss db on win32
util: move socket_init() to osdep.c
build-sys: must link with -fstack-protector
libcacard: fix mingw64 cross-compilation
libcacard: split vscclient main() from socket reading
libcacard: vscclient to use QemuThread for portability
libcacard: teach vscclient to use GMainLoop for portability
libcacard: remove sql: prefix
libcacard: remove default libcoolkey loading
Makefile | 8 +- Makefile.objs | 1 + configure | 8 +- hw/usb/ccid-card-emulated.c | 9 +- hw/usb/ccid-card-passthru.c | 63 +++++- hw/usb/dev-smartcard-reader.c | 243 +++++++++++++++----- include/qemu-common.h | 5 + libcacard/cac.c | 80 ++++--- libcacard/cac.h | 8 + libcacard/vcard_emul_nss.c | 47 ++-- libcacard/vcardt.c | 40 ++++ libcacard/vcardt.h | 5 - libcacard/vcardt_internal.h | 6 + libcacard/vreader.c | 77 +++++++ libcacard/vscclient.c | 506 +++++++++++++++++++++++++----------------- rules.mak | 4 +- util/cutils.c | 23 ++ util/osdep.c | 23 ++ util/qemu-sockets.c | 24 -- 19 files changed, 838 insertions(+), 342 deletions(-) create mode 100644 libcacard/vcardt.c create mode 100644 libcacard/vcardt_internal.h
Signature · 1 line
1.8.2