Skip to content

for spice post load char device hook

Alon Levy qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v10 of 5 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4char: add a post_load callbackinclude/char/char.h qemu-char.c+19 -028 replies
2/4virtio-serial: add a post_load callback implemented by porthw/virtio-serial-bus.c hw/virtio-serial.h+7 -00 replies
3/4virtio-console: implement post_load to call to qemu_chr_fe_post_loadhw/virtio-console.c+11 -00 replies
4/4spice-qemu-char: register interface on post loadspice-qemu-char.c+9 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/4] for spice post load char device hook

This reworks my former patch (http://patchwork.ozlabs.org/patch/227678/ - sorry Hans, can't find the version you posted) per Gerd's suggestion. Specifically it adds a new qemu_chr_fe_post_load api that is called by the front end and implemented by the backend. virtio-console implements it, adding it's own hook which is called by virtio-serial-bus upon post_load from the timer, so that qemu_chr_fe_post_load is called when the vm is already in the running state. This makes the spice-qemu-char usage very simple by not requiring yet another timer.

Note about the added api: I decided to pass "connected" via qemu_chr_fe_post_load in order not to introduce more api on qemu_chr_fe_.. for state querying, like qemu_chr_fe_is_connected, since I'm not sure it would make sense for other frontends.

v1 wasn't completely sent to the list, mistakenly sent before squashing one patch.

Alon Levy (4):
char: add a post_load callback
virtio-serial: add a post_load callback implemented by port
virtio-console: implement post_load to call to qemu_chr_fe_post_load
spice-qemu-char: register interface on post load

 hw/virtio-console.c    | 11 +++++++++++
 hw/virtio-serial-bus.c |  5 +++++
 hw/virtio-serial.h     |  2 ++
 include/char/char.h    | 12 ++++++++++++
 qemu-char.c            |  7 +++++++
 spice-qemu-char.c      |  9 +++++++++
 6 files changed, 46 insertions(+)
Signature · 1 line
1.8.1.4