RFC bttv: refactor audio_mux() and fix muting/unmuting
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest10 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"drivers/ | +4 | 1 reply | |
| 2/10 | bttv: audio_mux(): do not change the value of the v4l2 mute controldrivers/ | +4 | 1 reply | |
| 3/10 | bttv: do not save the audio input in audio_mux()drivers/ | +5 | 1 reply | |
| 4/10 | bttv: rename field 'audio' in struct 'bttv' to 'audio_input'drivers/ drivers/ drivers/ | +8 | 1 reply | |
| 5/10 | bttv: separate GPIO part from function audio_mux()drivers/ | +12 | 1 reply | |
| 6/10 | bttv: untangle audio input and mute settingdrivers/ | +24 | 1 reply | |
| 7/10 | bttv: do not unmute the device before the first opendrivers/ | +3 | 1 reply | |
| 8/10 | bttv: apply mute settings on opendrivers/ | +2 | 1 reply | |
| 9/10 | bttv: fix mute on last close of the video device nodedrivers/ | +1 | 2 replies | |
| 10/10 | bttv: avoid mute on last close when the radio device node is still opendrivers/ | +4 | 0 replies |
Reviews trailers per patch
8 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Hans Verkuil |
|---|---|
| 1/10 | A-b |
| 2/10 | A-b |
| 3/10 | A-b |
| 4/10 | A-b |
| 5/10 | A-b |
| 6/10 | A-b |
| 7/10 | A-b |
| 8/10 | A-b |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/10] bttv: refactor audio_mux() and fix muting/unmuting
This patch series refactors function audio_mux() and fixes several issues related to muting/unmuting on probing, first open and last close.
Two thirds of the changes have already been sent as part of the RFC patch series "bttv: fix muting/unmuting on probing, first open and last close" v1 and v2, the new patches 3-6 untagle the mute and input setting code as much as possible as suggested by hans Verkuil.
Tested with a Hauppauge WinTV Theatre (model 37284, Rev B421).
Frank Schäfer (10):
bttv: audio_mux(): use a local variable "gpio_mute" instead of
modifying the function parameter "mute"
bttv: audio_mux(): do not change the value of the v4l2 mute control
bttv: do not save the audio input in audio_mux()
bttv: rename field 'audio' in struct 'bttv' to 'audio_input'
bttv: separate GPIO part from function audio_mux()
bttv: untangle audio input and mute setting
bttv: do not unmute the device before the first open
bttv: apply mute settings on open
bttv: fix mute on last close of the video device node
bttv: avoid mute on last close when the radio device node is still
open
drivers/media/pci/bt8xx/bttv-cards.c | 2 +- drivers/media/pci/bt8xx/bttv-driver.c | 101 ++++++++++++++++++--------------- drivers/media/pci/bt8xx/bttvp.h | 2 +-
3 Dateien geändert, 57 Zeilen hinzugefügt(+), 48 Zeilen entfernt(-)
Signature · 1 line
1.7.10.4