Skip to content

New virtio PCI layout

Rusty Russell virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 71 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22virtio_config: introduce size-based accessors.include/linux/virtio_config.h+134 -270 replies
2/22virtio_config: use size-based accessors.drivers/block/virtio_blk.c drivers/char/virtio_console.c drivers/net/caif/caif_virtio.c +4 more+79 -950 replies
3/22virtio_config: make transports implement accessors.drivers/lguest/lguest_device.c drivers/net/caif/caif_virtio.c drivers/s390/kvm/kvm_virtio.c +4 more+283 -597 replies
4/22virtio: use u32, not bitmap for struct virtio_device's featuresdrivers/char/virtio_console.c drivers/lguest/lguest_device.c drivers/remoteproc/remoteproc_virtio.c +11 more+27 -542 replies
5/22virtio: add support for 64 bit features.drivers/char/virtio_console.c drivers/lguest/lguest_device.c drivers/remoteproc/remoteproc_virtio.c +9 more+41 -347 replies
6/22virtio: move vring structure into struct virtqueue.drivers/virtio/virtio_ring.c include/linux/virtio.h+54 -680 replies
7/22pci: add pci_iomap_rangeinclude/asm-generic/pci_iomap.h lib/pci_iomap.c+45 -60 replies
8/22virtio-pci: define layout for virtio vendor-specific capabilities.include/uapi/linux/virtio_pci.h+41 -00 replies
9/22virtio_pci: move old defines to legacy, introduce new structure.drivers/virtio/Kconfig drivers/virtio/Makefile drivers/virtio/virtio_pci.c +2 more+911 -8800 replies
10/22virtio_pci: use _LEGACY_ defines in virtio_pci_legacy.cdrivers/virtio/virtio_pci_legacy.c include/linux/virtio_pci.h include/uapi/linux/virtio_pci.h+43 -320 replies
11/22virtio_pci: don't use the legacy driver if we find the new PCI capabilities.drivers/virtio/virtio_pci_legacy.c include/linux/virtio_pci.h+35 -10 replies
12/22virtio_pci: allow duplicate capabilities.drivers/virtio/virtio_pci_legacy.c include/linux/virtio_pci.h+18 -525 replies
13/22virtio_pci: new, capability-aware driver.drivers/virtio/Makefile drivers/virtio/virtio_pci.c+980 -03 replies
14/22virtio_pci: layout changes as per hpa's suggestions.drivers/virtio/virtio_pci.c include/uapi/linux/virtio_pci.h+46 -130 replies
15/22virtio_pci: use little endian for config space.drivers/virtio/virtio_pci.c+41 -360 replies
16/22virtio_pci: use separate notification offsets for each vq.drivers/virtio/virtio_pci.c include/uapi/linux/virtio_pci.h+44 -1927 replies
17/22virtio_pci_legacy: cleanup struct virtio_pci_vq_infodrivers/virtio/virtio_pci_legacy.c+11 -100 replies
18/22virtio_pci: share structure between legacy and modern.drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c drivers/virtio/virtio_pci_legacy.c+116 -1560 replies
19/22virtio_pci: share interrupt/notify handlers between legacy and modern.drivers/virtio/Makefile drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h +2 more+131 -1580 replies
20/22virtio_pci: share virtqueue setup/teardown between modern and legacy driver.drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c +1 more+396 -6550 replies
21/22virtio_pci: simplify common helpers.drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c +1 more+29 -360 replies
22/22virtio_pci: fix finalize_features in modern driver.drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c +2 more+83 -480 replies

Reviews trailers per patch

1 of 22 patches has a Reviewed-by or Acked-by.

PatchPawel Moll
1/22
2/22
3/22
4/22
5/22A-b
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/22] New virtio PCI layout

I've renewed this again, with some comments from HPA. I've tried to keep the new patches separate, so you can see the changes since we last discussed this (and so it's easy to back it out if we decide it's insane).

I haven't even looked at the QEMU side so this is completely untested.

Comments gratefully received!
Rusty.

Michael S Tsirkin (1):
pci: add pci_iomap_range

Rusty Russell (21):
virtio_config: introduce size-based accessors.
virtio_config: use size-based accessors.
virtio_config: make transports implement accessors.
virtio: use u32, not bitmap for struct virtio_device's features
virtio: add support for 64 bit features.
virtio: move vring structure into struct virtqueue.
virtio-pci: define layout for virtio vendor-specific capabilities.
virtio_pci: move old defines to legacy, introduce new structure.
virtio_pci: use _LEGACY_ defines in virtio_pci_legacy.c
virtio_pci: don't use the legacy driver if we find the new PCI
capabilities.
virtio_pci: allow duplicate capabilities.
virtio_pci: new, capability-aware driver.
virtio_pci: layout changes as per hpa's suggestions.
virtio_pci: use little endian for config space.
virtio_pci: use separate notification offsets for each vq.
virtio_pci_legacy: cleanup struct virtio_pci_vq_info
virtio_pci: share structure between legacy and modern.
virtio_pci: share interrupt/notify handlers between legacy and
modern.
virtio_pci: share virtqueue setup/teardown between modern and legacy
driver.
virtio_pci: simplify common helpers.
virtio_pci: fix finalize_features in modern driver.

 drivers/block/virtio_blk.c             |   77 ++--
 drivers/char/virtio_console.c          |   17 +-
 drivers/lguest/lguest_device.c         |   89 +++-
 drivers/net/caif/caif_virtio.c         |   25 +-
 drivers/net/virtio_net.c               |   28 +-
 drivers/remoteproc/remoteproc_virtio.c |    8 +-
 drivers/s390/kvm/kvm_virtio.c          |   88 +++-
 drivers/s390/kvm/virtio_ccw.c          |   39 +-
 drivers/scsi/virtio_scsi.c             |   12 +-
 drivers/virtio/Kconfig                 |   12 +
 drivers/virtio/Makefile                |    3 +-
 drivers/virtio/virtio.c                |   18 +-
 drivers/virtio/virtio_balloon.c        |   10 +-
 drivers/virtio/virtio_mmio.c           |   55 ++-
 drivers/virtio/virtio_pci-common.c     |  395 ++++++++++++++++
 drivers/virtio/virtio_pci-common.h     |  121 +++++
 drivers/virtio/virtio_pci.c            |  777 ++++++++++++--------------------
 drivers/virtio/virtio_pci_legacy.c     |  481 ++++++++++++++++++++
 drivers/virtio/virtio_ring.c           |  116 ++---
 include/asm-generic/pci_iomap.h        |    5 +
 include/linux/virtio.h                 |   11 +-
 include/linux/virtio_config.h          |  205 +++++++--
 include/linux/virtio_pci.h             |   35 ++
 include/uapi/linux/virtio_config.h     |    2 +
 include/uapi/linux/virtio_pci.h        |  111 ++++-
 lib/pci_iomap.c                        |   46 +-
 net/9p/trans_virtio.c                  |    9 +-
 tools/virtio/linux/virtio.h            |   22 +-
 tools/virtio/linux/virtio_config.h     |    2 +-
 tools/virtio/virtio_test.c             |    5 +-
 tools/virtio/vringh_test.c             |   16 +-
 31 files changed, 2018 insertions(+), 822 deletions(-)
 create mode 100644 drivers/virtio/virtio_pci-common.c
 create mode 100644 drivers/virtio/virtio_pci-common.h
 create mode 100644 drivers/virtio/virtio_pci_legacy.c
 create mode 100644 include/linux/virtio_pci.h
Signature · 1 line
1.7.10.4