Skip to content

bttv: refactor audio_mux() and fix muting/unmuting

Frank Schäfer linux-media 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"drivers/media/pci/bt8xx/bttv-driver.c+4 -40 replies
2/8bttv: audio_mux(): do not change the value of the v4l2 mute controldrivers/media/pci/bt8xx/bttv-driver.c+4 -40 replies
3/8bttv: do not save the audio input in audio_mux()drivers/media/pci/bt8xx/bttv-driver.c+5 -50 replies
4/8bttv: rename field 'audio' in struct 'bttv' to 'audio_input'drivers/media/pci/bt8xx/bttv-cards.c drivers/media/pci/bt8xx/bttv-driver.c drivers/media/pci/bt8xx/bttvp.h+8 -80 replies
5/8bttv: separate GPIO part from function audio_mux()drivers/media/pci/bt8xx/bttv-driver.c+12 -60 replies
6/8bttv: untangle audio input and mute settingdrivers/media/pci/bt8xx/bttv-driver.c+24 -270 replies
7/8bttv: do not unmute the device before the first opendrivers/media/pci/bt8xx/bttv-driver.c+3 -10 replies
8/8bttv: apply mute settings on opendrivers/media/pci/bt8xx/bttv-driver.c+2 -10 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchHans Verkuil
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] bttv: refactor audio_mux() and fix muting/unmuting

This patch series refactors function audio_mux() and fixes several issues related to muting/unmuting on probing and first open.

Mute on last close will be fixed with further patches which are currently under review.

Tested with a Hauppauge WinTV Theatre (model 37284, Rev B421).

Frank Schäfer (8):
bttv: audio_mux(): use a local variable "gpio_mute" instead of
modifying the function parameter "mute"
bttv: audio_mux(): do not change the value of the v4l2 mute control
bttv: do not save the audio input in audio_mux()
bttv: rename field 'audio' in struct 'bttv' to 'audio_input'
bttv: separate GPIO part from function audio_mux()
bttv: untangle audio input and mute setting
bttv: do not unmute the device before the first open
bttv: apply mute settings on open

 drivers/media/pci/bt8xx/bttv-cards.c  |    2 +-
 drivers/media/pci/bt8xx/bttv-driver.c |   94 ++++++++++++++++++---------------
 drivers/media/pci/bt8xx/bttvp.h       |    2 +-

3 Dateien geändert, 52 Zeilen hinzugefügt(+), 46 Zeilen entfernt(-)

Signature · 1 line
1.7.10.4