Skip to content

iio:magnetometer:ak8975 cleanup and move out of staging.

Jonathan Cameron linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging:iio:magnetometer:ak8975 drop unused eoc_irqdrivers/staging/iio/magnetometer/ak8975.c+0 -20 replies
2/4staging:iio:magnetometer:ak8975 drop I2C_M_NOSTART flag in read_datadrivers/staging/iio/magnetometer/ak8975.c+0 -10 replies
3/4staging:iio:magnetometer:ak8975 use standard i2c_smbus read functions.drivers/staging/iio/magnetometer/ak8975.c+17 -490 replies
4/4iio:magnetometer:ak8975 move driver out of stagingdrivers/iio/magnetometer/Kconfig drivers/iio/magnetometer/Makefile drivers/iio/magnetometer/ak8975.c +3 more+497 -4970 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLaxman Dewangan
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] iio:magnetometer:ak8975 cleanup and move out of staging.

When I proposed moving this out of staging a while back, Lars-Peter pointed out a few 'unusual' elements in the driver. This series addresses those and the interesting question of what the NOSTART flag was doing there in the read code (came up in the dicussion of one of Lars-Peter's points).

The caching in the write is a little unnecessary, but isn't technically incorrect so I haven't touched that.

If anyone has one of these to test and make sure the changes haven't broken anything that would be great!

Thanks,

Jonathan

Jonathan Cameron (4):
staging:iio:magnetometer:ak8975 drop unused eoc_irq staging:iio:magnetometer:ak8975 drop I2C_M_NOSTART flag in read_data staging:iio:magnetometer:ak8975 use standard i2c_smbus read functions. iio:magnetometer:ak8975 move driver out of staging

 drivers/iio/magnetometer/Kconfig          |  11 +
 drivers/iio/magnetometer/Makefile         |   1 +
 drivers/iio/magnetometer/ak8975.c         | 485 ++++++++++++++++++++++++++++
 drivers/staging/iio/magnetometer/Kconfig  |  11 -
 drivers/staging/iio/magnetometer/Makefile |   1 -
 drivers/staging/iio/magnetometer/ak8975.c | 520 ------------------------------
 6 files changed, 497 insertions(+), 532 deletions(-)
 create mode 100644 drivers/iio/magnetometer/ak8975.c
 delete mode 100644 drivers/staging/iio/magnetometer/ak8975.c
Signature · 1 line
1.8.1.4